From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-3988-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 10005 invoked by alias); 9 Apr 2013 08:32:31 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 9992 invoked by uid 89); 9 Apr 2013 08:32:30 -0000
X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD autolearn=ham version=3.3.1
Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Apr 2013 08:32:30 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 7AB85A3A49;	Tue,  9 Apr 2013 10:32:25 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: David Holsgrove <david.holsgrove@xilinx.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,	Roland McGrath <roland@hack.frob.com>,	Joseph Myers <joseph@codesourcery.com>,	John Williams <jwilliams@xilinx.com>,	Edgar Iglesias <edgari@xilinx.com>,	Vinod Kathail <vinodk@xilinx.com>,	Vidhumouli Hunsigida <vidhum@xilinx.com>,	Nagaraju Mekala <nmekala@xilinx.com>, Tom Shui <tshui@xilinx.com>
Subject: Re: [PATCH v2 2/2] Add MicroBlaze Port
References: <1364652885-28535-1-git-send-email-david.holsgrove@xilinx.com>	<e57570bc-a47e-4918-8dc7-a12548f571f2@CO1EHSMHS028.ehs.local>	<Pine.LNX.4.64.1304022325380.24069@digraph.polyomino.org.uk>	<07006b79-5868-4bde-ba30-5739c3e3857f@CH1EHSMHS018.ehs.local>
X-Yow: It's today's SPECIAL!
Date: Tue, 09 Apr 2013 08:32:00 -0000
In-Reply-To: <07006b79-5868-4bde-ba30-5739c3e3857f@CH1EHSMHS018.ehs.local>	(David Holsgrove's message of "Tue, 9 Apr 2013 08:20:00 +0000")
Message-ID: <mvm7gkc2jfr.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00029.txt.bz2

David Holsgrove <david.holsgrove@xilinx.com> writes:

> +inline long
> +get_frame_size (unsigned long instr)
> +{
> +    return abs ((short signed) (instr & 0xFFFF));
> +}
> +
> +static unsigned long *
> +find_frame_creation (unsigned long *pc)
> +{
> +    int i;

Two spaces indent.

> +
> +    /* NOTE: Distance to search is arbitrary
> +     *   250 works well for most things,
> +     *   750 picks up things like tcp_recvmsg(),
> +     *  1000 needed for fat_fill_super().  */

No initial * in comments.  No () when referring to functions, instead of
actual calls.

> +            if ((!(*pprev_pc) || ((*pprev_pc) & 3)))

The innermost parens are confusing and redundant, likewise for the outer
pair.

> +    array[0]=(void *)pc;

Space around operators and after the cast.

> +#define atomic_compare_and_exchange_val_acq(mem, newval, oldval)              \
> +  ({                                                                          \
> +    __typeof (*(mem)) __result;                                               \
> +    if (sizeof (*mem) == 4)                                                   \
> +      __result = __arch_compare_and_exchange_val_32_acq(mem, newval, oldval); \

Space before open paren.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."