From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4135-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 24960 invoked by alias); 14 May 2013 07:47:04 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 24950 invoked by uid 89); 14 May 2013 07:47:03 -0000
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_CP,TW_HW autolearn=ham version=3.3.1
Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 07:47:03 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 5BF77A4EB7;	Tue, 14 May 2013 09:47:01 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use   NEON when compiler does
References: <20130513224722.9F17C2C05E@topped-with-meat.com>
X-Yow: ..  hubub, hubub, HUBUB, hubub, hubub, hubub, HUBUB, hubub, hubub, hubub.
Date: Tue, 14 May 2013 07:47:00 -0000
In-Reply-To: <20130513224722.9F17C2C05E@topped-with-meat.com> (Roland	McGrath's message of "Mon, 13 May 2013 15:47:22 -0700 (PDT)")
Message-ID: <mvmip2mype2.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00055.txt.bz2

Roland McGrath <roland@hack.frob.com> writes:

>    IFUNC_IMPL (i, name, memcpy,
>  	      IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> -			      __memcpy_neon)
> +#ifdef __ARM_NEON__
> +                              memcpy
> +#else
> +			      __memcpy_neon
> +#endif
> +                              )

Preprocessor directives in macro arguments give undefined behaviour.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."