From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buffalo.birch.relay.mailchannels.net (buffalo.birch.relay.mailchannels.net [23.83.209.24]) by sourceware.org (Postfix) with ESMTPS id EBD853858034 for ; Mon, 13 Dec 2021 16:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBD853858034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DA8778618AE; Mon, 13 Dec 2021 16:53:35 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E2A86861323; Mon, 13 Dec 2021 16:53:34 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.114.196.226 (trex/6.4.3); Mon, 13 Dec 2021 16:53:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Slimy-Duck: 251e5cec2b54e1b8_1639414415495_901217850 X-MC-Loop-Signature: 1639414415495:3093015550 X-MC-Ingress-Time: 1639414415494 Received: from [192.168.52.116] (unknown [223.185.62.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4JCSJD3FDBz11; Mon, 13 Dec 2021 08:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1639414414; bh=LcNAbrSZMPd938CXxy23kPWdeU8=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=w9JmyFg+Xt5jgWxGqeRfIlrK51CrrjlVtMUNA3fJxMhypNbePqEhzi4i9NpUca13n QQ1i4FHXacd3yhjksJBx7AKFwzwwdDUItempKEBF7qsnhKJxsIukxmVkw7SkVnBwpl gPpR536HrsYftUzuae5JFp18DBzEsnZ5BNzxzKHU= Message-ID: <02a334f6-a43b-db0b-d3a3-13bcf49f932f@gotplt.org> Date: Mon, 13 Dec 2021 22:23:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] Use $(pie-default) with conformtest Content-Language: en-US To: libc-stable@sourceware.org Cc: fweimer@redhat.com, Joseph Myers References: <20211213153313.3770431-1-siddhesh@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: <20211213153313.3770431-1-siddhesh@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3038.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 16:53:40 -0000 Sorry, this should have been [committed 2.34] Siddhesh On 12/13/21 21:03, Siddhesh Poyarekar via Libc-stable wrote: > From: Joseph Myers > > My glibc bot showed that my conformtest changes fail the build of the > conformtest execution tests for x86_64-linux-gnu-static-pie, because > linking the newly built object with the newly built libc and the > associated options normally used for linking requires it to be built > as PIE. Add $(pie-default) to the compiler command used so that PIE > options are used when required. > > There's a case for using the whole of $(CFLAGS-.o) (which includes > $(pie-default)), but that raises questions of any impact from using > optimization flags from CFLAGS in these tests. So for now just use > $(pie-default) as the key part of $(CFLAGS-.o) that's definitely > needed. > > Tested with build-many-glibcs.py for x86_64-linux-gnu-static-pie. > > (cherry picked from commit 885762aa31d75de8b9fea4c0e2e372b582d4c548) > --- > conform/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/conform/Makefile b/conform/Makefile > index 296db818f0..27ad98caf8 100644 > --- a/conform/Makefile > +++ b/conform/Makefile > @@ -175,7 +175,8 @@ $(conformtest-header-tests): $(objpfx)%/conform.out: \ > conformtest.py $(conformtest-headers-data) > (set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \ > mkdir -p $(@D); \ > - $(PYTHON) $< --cc='$(CC)' --flags='$(conformtest-cc-flags)' \ > + $(PYTHON) $< --cc='$(CC) $(pie-default)' \ > + --flags='$(conformtest-cc-flags)' \ > --ldflags='$(+link-tests-before-inputs)' \ > --libs='$(+link-tests-after-inputs)' \ > --run-program-prefix='$(run-program-prefix)' \ >