From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120404 invoked by alias); 18 Oct 2018 10:38:20 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 120278 invoked by uid 89); 18 Oct 2018 10:38:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=2.29, Hx-languages-length:1035 X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 10:38:18 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9IAYtTX017284 for ; Thu, 18 Oct 2018 06:38:16 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2n6n4e0quv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Oct 2018 06:38:16 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Oct 2018 11:38:14 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Oct 2018 11:38:10 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9IAc9wc66650176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 18 Oct 2018 10:38:09 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91FF84C044; Thu, 18 Oct 2018 10:38:09 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65EF24C052; Thu, 18 Oct 2018 10:38:09 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.152.222.136]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 18 Oct 2018 10:38:09 +0000 (GMT) Subject: [COMMITTED 2.27 / 2.28] Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275] To: libc-stable@sourceware.org References: <874ldm3v09.fsf@oldenburg.str.redhat.com> <20603cf9-6427-d7da-8bf6-b2eed6abb61a@linux.ibm.com> Cc: libc-alpha@sourceware.org, Florian Weimer From: Stefan Liebler Date: Mon, 01 Jan 2018 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20603cf9-6427-d7da-8bf6-b2eed6abb61a@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-IE Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18101810-0016-0000-0000-00000214E0AD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101810-0017-0000-0000-0000326C8180 Message-Id: <0b9dbba4-26d0-e87d-086c-9705c10ef46c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-17_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810180101 X-SW-Source: 2018-10/txt/msg00002.txt.bz2 On 10/17/2018 12:28 PM, Stefan Liebler wrote: > On 10/16/2018 03:01 PM, Florian Weimer wrote: >> * Stefan Liebler: >> >>> The flag PTHREAD_MUTEX_NO_ELISION_NP is not explicitly checked before >>> FORCE_ELISION is called. But only one of those two flags can be set. >>> Your remaining assumption is correct. >>> I've changed the comment in the three force-elision.h files. Is this >>> okay? >> >> The comment looks good to me know.  Thanks! >> >> Florian >> > Committed, bugzilla closed and target milestone is set to 2.29. > > Thanks, > Stefan > Starting with glibc 2.27, the configure switch --enable-lock-elision was removed with commit "Add elision tunables" (https://sourceware.org/git/?p=glibc.git;a=commit;h=07ed18d26a342741cb25a4739158c65ed9dd4d09). Now you can use lock-elision by just setting the tunables environment variable. Therefore I've cherry picked this patch to release branch 2.27 / 2.28. Bye Stefan