From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85490 invoked by alias); 17 Dec 2016 15:24:10 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 85406 invoked by uid 89); 17 Dec 2016 15:24:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*Ad:U*libc-stable, HTo:U*libc-stable X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-wm0-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=GyAoxH093CPfHTkgdr/feJI0wO9mkTlaD9AcVBvOZNI=; b=uMeY0pxge+HW94vMs0yIY+H7seQdvCTlkLydWmLn8uhEl//K8nj0wIhXFRCEv42z53 E15R3McJI5CcEwQNRRvFCsgCjOPt30wNrPMZ4Ry1Ny9BbGHWofHqbL117GixeeZpD2os vP5une5Mr8qye66OQLkL+KyVjfrBzrTlcSmrb7rVL1CIS5/2x1VC4jZs1RTTy7K3qMi8 Zp9SaSs8qco85tv0TJ5olsSrEY61c3H3DdJvSgfdlQ2NJlrGHiV7Fl/jUs/LEThd8mJS 6p9st8dcLhAWeeAF/VTLglvhwNAXdjJdB1q+5MWWasMSgJCpArbf2N3lwLP/o+jHUxgG dh1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=GyAoxH093CPfHTkgdr/feJI0wO9mkTlaD9AcVBvOZNI=; b=H5htc+UoyX2IHDeYbiE/zDgsnpo2j9kKhjXvzhviS+7vhdG4C0MeHkZa8XS4svHN2s L5ujNZafxsUrRWHZnRPYYFa5p/wHdlJFAisd+p0Hd1wPg51jKGnLISTqikh39wkhHNe8 CUUoLChpgmkQmfJynzM2WCMntiO+SBfpTeK0D/2kZPNx6zKDkhVyqLE/cpStefA86jiE KRfB6Dhlw74gVGMuanvSotTFZuERuPmy8s3O+qUJelrB7m0unW5bXr9yN5qVubBhv/Ba MvD83F3qs8oKAA05zAMPgnNwdRh2LqO0Y18RV1Sl+/fwzVJHo9yh0euZ2aCf/IfC2bSw pxug== X-Gm-Message-State: AIkVDXKHyFWb66OsSOxXSmJfIYNqY7lu+DVQxgIyzEv4tIOxoIP7g0VbHkvJLl9Ymcnzhg== X-Received: by 10.28.91.141 with SMTP id p135mr6601327wmb.128.1481988234741; Sat, 17 Dec 2016 07:23:54 -0800 (PST) From: =?UTF-8?q?=C3=89tienne=20Buira?= To: libc-stable@sourceware.org Subject: [PATCH] x86_64: check for SHARED instead of PIC where sensible Date: Fri, 01 Jan 2016 00:00:00 -0000 Message-Id: <20161217152344.19910-1-etienne.buira@gmail.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-12/txt/msg00000.txt.bz2 This caused build issues where jb HIDDEN_JUMPTARGET (symname) were expanded to jb *symname@GOTPCREL(%rip), which is not encodable as Jcc requires immediate. PIC were defined because the compiler defaulted to -fPIC. Only tested on Linux x86_64 without avx512. Some test fails, but it looks unrelated. * sysdeps/x86_64/sysdep.h: Check for SHARED instead of PIC * sysdeps/x86_64/mempcpy_chk.S: ditto * sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S: ditto --- ChangeLog | 7 +++++++ sysdeps/x86_64/mempcpy_chk.S | 2 +- sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S | 2 +- sysdeps/x86_64/sysdep.h | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 06360aa..527c832 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2016-12-17 Étienne Buira + + x86_64: check for SHARED instead of PIC where sensible + * sysdeps/x86_64/sysdep.h: Check for SHARED instead of PIC + * sysdeps/x86_64/mempcpy_chk.S: ditto + * sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S: ditto + 2016-08-02 Aurelien Jarno 2016-08-02 Aurelien Jarno diff --git a/sysdeps/x86_64/mempcpy_chk.S b/sysdeps/x86_64/mempcpy_chk.S index 390abc6..4ed9c91 100644 --- a/sysdeps/x86_64/mempcpy_chk.S +++ b/sysdeps/x86_64/mempcpy_chk.S @@ -19,7 +19,7 @@ #include #include "asm-syntax.h" -#ifndef PIC +#ifndef SHARED /* For libc.so this is defined in memcpy.S. For libc.a, this is a separate source to avoid mempcpy bringing in __chk_fail and all routines diff --git a/sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S b/sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S index 9687df0..981cfde 100644 --- a/sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S +++ b/sysdeps/x86_64/multiarch/memset-avx512-no-vzeroupper.S @@ -27,7 +27,7 @@ #endif .section .text.avx512,"ax",@progbits -#if defined PIC +#if defined SHARED ENTRY (MEMSET_CHK) cmpq %rdx, %rcx jb HIDDEN_JUMPTARGET (__chk_fail) diff --git a/sysdeps/x86_64/sysdep.h b/sysdeps/x86_64/sysdep.h index 75ac747..9ae0e0f 100644 --- a/sysdeps/x86_64/sysdep.h +++ b/sysdeps/x86_64/sysdep.h @@ -89,7 +89,7 @@ lose: \ END (name) #undef JUMPTARGET -#ifdef PIC +#ifdef SHARED # ifdef BIND_NOW # define JUMPTARGET(name) *name##@GOTPCREL(%rip) # else -- 2.10.2