From: "Dmitry V. Levin" <ldv@altlinux.org>
To: libc-stable@sourceware.org
Subject: [2.27 COMMITTED] Fix posix/tst-glob_lstat_compat on alpha [BZ #22818]
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <20180219222259.GD7379@altlinux.org> (raw)
From: Aurelien Jarno <aurelien@aurel32.net>
The tst-glob_lstat_compat test needs to run tests on the previous
version of glob. On alpha, there are three versions of glob, GLIBC_2.0,
GLIBC_2.1 and GLIBC_2.27, while on other architectures there are only
the GLIBC_2.0 and GLIBC_2.27 version. Therefore on alpha the previous
version is GLIBC_2.1 and not GLIBC_2.0.
Changelog:
[BZ #22818]
* posix/tst-glob_lstat_compat.c [__alpha__] (glob): Access
the GLIBC_2.1 version.
(cherry picked from commit f8d79582896c52cc2b50bdd030a3ec27ef23b587)
---
ChangeLog | 6 ++++++
NEWS | 1 +
posix/tst-glob_lstat_compat.c | 7 +++++++
3 files changed, 14 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 4c0b250..25624b6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2018-02-18 Aurelien Jarno <aurelien@aurel32.net>
+
+ [BZ #22818]
+ * posix/tst-glob_lstat_compat.c [__alpha__] (glob): Access
+ the GLIBC_2.1 version.
+
2018-02-02 Sean McKean <smckean83@gmail.com>
[BZ #22735]
diff --git a/NEWS b/NEWS
index d7f1567..e40fa8d 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,7 @@ The following bugs are resolved with this release:
configured with --enable-default-pie
[22735] Misleading typo in time.h source comment regarding CLOCKS_PER_SECOND
[22797] Linux: use reserved name __key in pkey_get
+ [22818] posix/tst-glob_lstat_compat failure on alpha
[22827] RISC-V ELF64 parser mis-reads flag in ldconfig
\f
diff --git a/posix/tst-glob_lstat_compat.c b/posix/tst-glob_lstat_compat.c
index c46bc9e..22cd1f0 100644
--- a/posix/tst-glob_lstat_compat.c
+++ b/posix/tst-glob_lstat_compat.c
@@ -35,7 +35,14 @@
#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_27)
__typeof (glob) glob;
+/* On alpha glob exists in version GLIBC_2_0, GLIBC_2_1, and GLIBC_2_27.
+ This test needs to access the version prior to GLIBC_2_27, which is
+ GLIBC_2_1 on alpha, GLIBC_2_0 elsewhere. */
+# ifdef __alpha__
+compat_symbol_reference (libc, glob, glob, GLIBC_2_1);
+# else
compat_symbol_reference (libc, glob, glob, GLIBC_2_0);
+# endif
/* Compat glob should not call gl_lstat since for some old binaries it
might be unitialized (for instance GNUmake). Check if it is indeed
--
ldv
reply other threads:[~2018-02-19 22:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219222259.GD7379@altlinux.org \
--to=ldv@altlinux.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).