From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36909 invoked by alias); 4 Feb 2019 21:32:18 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 36891 invoked by uid 89); 4 Feb 2019 21:32:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT autolearn=no version=3.3.2 spammy=H*r:4.89, wednesday, UD:aurel32.net, firm X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: hall.aurel32.net Received: from hall.aurel32.net (HELO hall.aurel32.net) (163.172.24.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Feb 2019 21:32:15 +0000 Received: from [2a01:e35:2e4c:a861:655e:aef3:f589:b897] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gqlqf-0007sP-Bl; Mon, 04 Feb 2019 22:32:13 +0100 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.92-RC4) (envelope-from ) id 1gqlqe-00040d-NY; Mon, 04 Feb 2019 22:32:12 +0100 Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Aurelien Jarno To: Florian Weimer Cc: Carlos O'Donell , libc-stable@sourceware.org Subject: Re: Backporting CVE-2016-10739 Message-ID: <20190204213212.GD15137@aurel32.net> References: <871s4nppu4.fsf@oldenburg2.str.redhat.com> <87r2cno9qq.fsf@oldenburg2.str.redhat.com> <0a9daa70-7ea9-1ebd-8690-04b6ff2acd88@redhat.com> <87munbo8wy.fsf@oldenburg2.str.redhat.com> <47ca567f-7120-19c5-7ed6-c67c9f6306ca@redhat.com> <87y36vmsr9.fsf@oldenburg2.str.redhat.com> <877eefmk3z.fsf@oldenburg2.str.redhat.com> <2e644830-b506-f5b6-e020-99fc9ee9b94f@redhat.com> <87h8djl16h.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h8djl16h.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00020.txt.bz2 On 2019-02-04 21:59, Florian Weimer wrote: > * Carlos O'Donell: > > >> Patch below. What do you think? > > > > This looks good to me, you make direct use of "__attribute__ > > ((visibility ("hidden")))" in an exceptional case, and that's fine. > > > If this becomes less rare for some reason we might want a > > libc-symbols.h macro to define something that expresses the intent of > > the hidden visibility e.g. attr_dup_sym_hidden. > > I'm not a firm believer in those macros. The fact that attribute_hidden > expanded to nothing at all was quite a surprise to me. > > I've pushed the last version. > > Aurelien, I will not be able to do any more backports before Wednesday, > so please feel free to take over. Thanks, I'll work on that for the 2.24 branch. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net