From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75124 invoked by alias); 22 Nov 2019 12:35:15 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 75108 invoked by uid 89); 22 Nov 2019 12:35:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-18.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 12:35:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574426112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A5eW+SaA/F+7mg8oUbAP36QeDJ4DmrcOwd9Db3UtYSo=; b=Uki0IBiVi0O4YTTk8qvhrBSSnFxfJ8nMvLhkFxSrO4eCYgoc6a1EJqhx3PHw1syt+ckMxc zPVBHSkpbadopMrxYAViRlMbnzU7RxNAT5VLnm999Snyji9dcumA/iXFz8dm9ahwmfVNLe sVcNZ/+SIGZpDJHsOpq8LwqqHARgRqA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-quvHXoEYMSidjoEYYjRqNA-1; Fri, 22 Nov 2019 07:35:10 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D314107ACC7 for ; Fri, 22 Nov 2019 12:35:09 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-200.str.redhat.com [10.33.192.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FFF85C553 for ; Fri, 22 Nov 2019 12:35:09 +0000 (UTC) Received: by oldenburg2.str.redhat.com (Postfix, from userid 1000) id DFCB7B703A14; Fri, 22 Nov 2019 13:35:07 +0100 (CET) Date: Tue, 01 Jan 2019 00:00:00 -0000 To: libc-stable@sourceware.org Subject: [2.29 COMMITTED] rtld: Check __libc_enable_secure before honoring LD_PREFER_MAP_32BIT_EXEC (CVE-2019-19126) [BZ #25204] User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20191122123507.DFCB7B703A14@oldenburg2.str.redhat.com> From: Florian Weimer X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: quvHXoEYMSidjoEYYjRqNA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00024.txt.bz2 From: Marcin Ko=C5=9Bcielnicki The problem was introduced in glibc 2.23, in commit b9eb92ab05204df772eb4929eccd018637c9f3e9 ("Add Prefer_MAP_32BIT_EXEC to map executable pages with MAP_32BIT"). (cherry picked from commit d5dfad4326fc683c813df1e37bbf5cf920591c8e) Change-Id: Ib782573b4623ee3edfa9f98ad62f69b9d8edcb27 diff --git a/NEWS b/NEWS index 5dc41ff3eb..4ad7c47d5f 100644 --- a/NEWS +++ b/NEWS @@ -35,6 +35,7 @@ The following bugs are resolved with this release: [24744] io: Remove the copy_file_range emulation [24986] alpha: new getegid, geteuid and getppid syscalls used unconditionally + [25204] Ignore LD_PREFER_MAP_32BIT_EXEC for SUID programs =20 Security related changes: =20 diff --git a/sysdeps/unix/sysv/linux/x86_64/64/dl-librecon.h b/sysdeps/unix= /sysv/linux/x86_64/64/dl-librecon.h index 975cbe2950..df2cdfdb6b 100644 --- a/sysdeps/unix/sysv/linux/x86_64/64/dl-librecon.h +++ b/sysdeps/unix/sysv/linux/x86_64/64/dl-librecon.h @@ -31,7 +31,8 @@ environment variable, LD_PREFER_MAP_32BIT_EXEC. */ #define EXTRA_LD_ENVVARS \ case 21: \ - if (memcmp (envline, "PREFER_MAP_32BIT_EXEC", 21) =3D=3D 0) \ + if (!__libc_enable_secure \ + && memcmp (envline, "PREFER_MAP_32BIT_EXEC", 21) =3D=3D 0) \ GLRO(dl_x86_cpu_features).feature[index_arch_Prefer_MAP_32BIT_EXEC] \ |=3D bit_arch_Prefer_MAP_32BIT_EXEC; \ break;