From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id 00206385E000 for ; Tue, 24 Mar 2020 11:54:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 00206385E000 Received: by mail-qt1-x841.google.com with SMTP id m33so14636462qtb.3 for ; Tue, 24 Mar 2020 04:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=vv2v/nhtl8UEUJpEsYl1T8u3vcApEW8dNGYRe6C44XM=; b=V2yu1noU4WgJhB94SswpmdO4OiHWvAEGmUjLJ7Yzk1jAkhDHTouHVNnhYHq8tWlpPn 4Uie39IwzN/8zAeONWO153JLGPIhRx9ozOfbrGQ3oSKZoWSLKcsHkPG0SU66RNr1LBcL qltxxnQrcLOV/5ovD7sLZo8SfnTgTpSfZWPC1mVYZ+l9n/wbUyqDoYMIO1Qka9pH3qaU 6VwG+/nMfruQwQrPIVYKrF5r7pK7qgkJMV1lsKSRbNjZM+YGqwkxHPeK0ibcOiC03vNE MZ7gT0YIxeeZNGpZvve5v0kn1N57zuSmIGRdTQyeKCGvkn6h/Vr73Bp8d+MwDQ0cimUJ eDYw== X-Gm-Message-State: ANhLgQ2Tk0M+Mx9okMwaPnY0yUTpjo/3+EIBx+qjJleRB5U2hdytXwyi WqN2FvhcXCWqtGpC+vr7OwzOrtgnavs= X-Google-Smtp-Source: ADFU+vtwcFpqzOw31TcHIwLeOgiXKuosON7hwLPLE53GsXtK0YKc1xgq2he7SePuw3aFag+lSl6MGA== X-Received: by 2002:aed:3225:: with SMTP id y34mr25826525qtd.19.1585050894323; Tue, 24 Mar 2020 04:54:54 -0700 (PDT) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id o81sm13302910qke.24.2020.03.24.04.54.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 04:54:54 -0700 (PDT) From: Adhemerval Zanella To: libc-stable@sourceware.org Subject: [COMMITTED] arm: Fix softp-fp Implies (BZ #25635) Date: Tue, 24 Mar 2020 08:52:48 -0300 Message-Id: <20200324115250.688467-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200324115250.688467-1-adhemerval.zanella@linaro.org> References: <20200324115250.688467-1-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-27.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 11:54:56 -0000 The commit "arm: Split BE/LE abilist" (1673ba87fefe019c834c09d33673d1d453ea698d) changed the soft-fp order for ARM selection when __SOFTFP__ is defined by the compiler. On 2.30 the sysdeps order is: 2.30 sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic While on master is: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/ieee754 sysdeps/generic It make the build select some routines (fadd, fdiv, fmul, fsub, and fma) on ieee754/flt-32 and ieee754/dbl-64 that requires fenv support to be correctly rounded which in turns lead to math failures since the __SOFTFP__ does not have fenv support. With this patch the order is now: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptlsysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le/nofpu sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic Checked on arm-linux-gnuaebi. (cherry picked from commit af09e5e5d9ec3ca20891e61a6922eac984fcbdc4) --- NEWS | 1 + sysdeps/arm/be/nofpu/Implies | 1 + sysdeps/arm/le/nofpu/Implies | 1 + 3 files changed, 3 insertions(+) create mode 100644 sysdeps/arm/be/nofpu/Implies create mode 100644 sysdeps/arm/le/nofpu/Implies diff --git a/NEWS b/NEWS index 76cfbcaa16..1dabaf9329 100644 --- a/NEWS +++ b/NEWS @@ -45,6 +45,7 @@ The following bugs are resolved with this release: [25401] Remove incorrect alloc_size attribute from pvalloc [25487] sinl() stack corruption from crafted input (CVE-2020-10029) [25523] MIPS/Linux inline syscall template is miscompiled + [25635] arm: Wrong sysdep order selection for soft-fp Version 2.30 diff --git a/sysdeps/arm/be/nofpu/Implies b/sysdeps/arm/be/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/be/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu diff --git a/sysdeps/arm/le/nofpu/Implies b/sysdeps/arm/le/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/le/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu -- 2.17.1