From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by sourceware.org (Postfix) with ESMTPS id C4C593858D35; Sat, 9 May 2020 19:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C4C593858D35 Received: by mail-pg1-x541.google.com with SMTP id r10so2013064pgv.8; Sat, 09 May 2020 12:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iVKrDSfwwiZuCmFpocu2wQq1tCpEZ60pB/qROB0mlNo=; b=UmyqdjUNGgnivODEs+Y0AKQIbnd+xlhWjKw9xjRvjDt+3MvHyk90tL7G1yCSaWVbUZ A4+nDFHTJhdO+kpo2GyNO6zVG1Fk2/HrXTLe2Ve5AGHQyDNNWkcFOZmgJl1BxJyFx4+O 5CnTHlKvVz6y3JTCWtmUJlyTJYoczzTB8kGKj0dlvobk1aPLLm+Ovz/WlkT3qOtgl0q1 VKWP2bMow3sK/+kLe9n4ShKMzmFM6E6HnPPj7lttBvMFk0CBfmH+gYR+MzsfCxSWW/ih AaZZFaJYOuxNAeOjVtIsIQWRHg3HpczzrBf3W+7/0gblnnxeP3XY6OhSC8YUbOWDUuAc jjYw== X-Gm-Message-State: AGi0PuahHjZ8m10LlRvYuz98iX2QvPwJIVu0cGqcazSoStd6WpkRBczc F+cUWi7cidtFpVJWISGfCFdT0JID X-Google-Smtp-Source: APiQypIL/i68Rd8tjqgMY/3zJD5yp/rXHCTau4sm+K7DHauTjlnI9W2V09HsvcVeclea+sBSJu+4bA== X-Received: by 2002:a63:fb14:: with SMTP id o20mr7840643pgh.144.1589052320744; Sat, 09 May 2020 12:25:20 -0700 (PDT) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id p64sm5586270pjp.7.2020.05.09.12.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2020 12:25:20 -0700 (PDT) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 8B1D81A0118; Sat, 9 May 2020 12:25:19 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: libc-stable@sourceware.org Subject: [PATCH] x86-64: Use RDX_LP on __x86_shared_non_temporal_threshold [BZ #25966] Date: Sat, 9 May 2020 12:25:19 -0700 Message-Id: <20200509192519.2918707-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 May 2020 19:25:23 -0000 Since __x86_shared_non_temporal_threshold is defined as long int __x86_shared_non_temporal_threshold; and long int is 4 bytes for x32, use RDX_LP to compare against __x86_shared_non_temporal_threshold in assembly code. I am checking it in and will backport it to 2.31/2.30 branches. H.J. --- sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S index c763b7d871..74953245aa 100644 --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S @@ -244,7 +244,7 @@ L(return): ret L(movsb): - cmpq __x86_shared_non_temporal_threshold(%rip), %rdx + cmp __x86_shared_non_temporal_threshold(%rip), %RDX_LP jae L(more_8x_vec) cmpq %rsi, %rdi jb 1f @@ -402,7 +402,7 @@ L(more_8x_vec): addq %r8, %rdx #if (defined USE_MULTIARCH || VEC_SIZE == 16) && IS_IN (libc) /* Check non-temporal store threshold. */ - cmpq __x86_shared_non_temporal_threshold(%rip), %rdx + cmp __x86_shared_non_temporal_threshold(%rip), %RDX_LP ja L(large_forward) #endif L(loop_4x_vec_forward): @@ -454,7 +454,7 @@ L(more_8x_vec_backward): subq %r8, %rdx #if (defined USE_MULTIARCH || VEC_SIZE == 16) && IS_IN (libc) /* Check non-temporal store threshold. */ - cmpq __x86_shared_non_temporal_threshold(%rip), %rdx + cmp __x86_shared_non_temporal_threshold(%rip), %RDX_LP ja L(large_backward) #endif L(loop_4x_vec_backward): -- 2.26.2