public inbox for
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <>
Cc: Nikita Popov <>
Subject: [committed 2.33 1/2] librt: fix NULL pointer dereference (bug 28213)
Date: Tue, 17 Aug 2021 19:23:18 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Nikita Popov <>

Helper thread frees copied attribute on NOTIFY_REMOVED message
received from the OS kernel.  Unfortunately, it fails to check whether
copied attribute actually exists (data.attr != NULL).  This worked
earlier because free() checks passed pointer before actually
attempting to release corresponding memory.  But
__pthread_attr_destroy assumes pointer is not NULL.

So passing NULL pointer to __pthread_attr_destroy will result in
segmentation fault.  This scenario is possible if
notification->sigev_notify_attributes == NULL (which means default
thread attributes should be used).

Signed-off-by: Nikita Popov <>
Reviewed-by: Siddhesh Poyarekar <>
(cherry picked from commit b805aebd42364fe696e417808a700fdb9800c9e8)
 sysdeps/unix/sysv/linux/mq_notify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/unix/sysv/linux/mq_notify.c b/sysdeps/unix/sysv/linux/mq_notify.c
index 6f46d29d1d..1714e1cc5f 100644
--- a/sysdeps/unix/sysv/linux/mq_notify.c
+++ b/sysdeps/unix/sysv/linux/mq_notify.c
@@ -132,7 +132,7 @@ helper_thread (void *arg)
 	       to wait until it is done with it.  */
 	    (void) __pthread_barrier_wait (&notify_barrier);
-      else if (data.raw[NOTIFY_COOKIE_LEN - 1] == NOTIFY_REMOVED)
+      else if (data.raw[NOTIFY_COOKIE_LEN - 1] == NOTIFY_REMOVED && data.attr != NULL)
 	  /* The only state we keep is the copy of the thread attributes.  */
 	  pthread_attr_destroy (data.attr);

  reply	other threads:[~2021-08-17 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 13:53 [committed 2.32 " Siddhesh Poyarekar
2021-08-17 13:53 ` Siddhesh Poyarekar [this message]
2021-08-17 13:53 ` [committed 2.32 2/2] librt: add test " Siddhesh Poyarekar
2021-08-17 13:53 ` [committed 2.33 " Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).