From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-stable@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>,
Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: [COMMITTED 2.33 2/3] CVE-2022-23219: Buffer overflow in sunrpc clnt_create for "unix" (bug 22542)
Date: Tue, 18 Jan 2022 07:49:25 +0100 [thread overview]
Message-ID: <20220118064926.1160592-2-aurelien@aurel32.net> (raw)
In-Reply-To: <20220118064926.1160592-1-aurelien@aurel32.net>
From: Florian Weimer <fweimer@redhat.com>
Processing an overlong pathname in the sunrpc clnt_create function
results in a stack-based buffer overflow.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
(cherry picked from commit 226b46770c82899b555986583294b049c6ec9b40)
---
NEWS | 5 +++++
sunrpc/clnt_gen.c | 10 +++++++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/NEWS b/NEWS
index 6e4221ca86..71bc4932a0 100644
--- a/NEWS
+++ b/NEWS
@@ -19,10 +19,15 @@ Security related changes:
issue when using a notification type of SIGEV_THREAD and a thread
attribute with a non-default affinity mask.
+ CVE-2022-23219: Passing an overlong file name to the clnt_create
+ legacy function could result in a stack-based buffer overflow when
+ using the "unix" protocol. Reported by Martin Sebor.
+
The following bugs are resolved with this release:
[15271] dlfcn function failure after dlmopen terminates process
[18435] pthread_once hangs when init routine throws an exception
+ [22542] CVE-2022-23219: Buffer overflow in sunrpc clnt_create for "unix"
[23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN)
crashes
[27304] pthread_cond_destroy does not pass private flag to futex system calls
diff --git a/sunrpc/clnt_gen.c b/sunrpc/clnt_gen.c
index 13ced8994e..b44357cd88 100644
--- a/sunrpc/clnt_gen.c
+++ b/sunrpc/clnt_gen.c
@@ -57,9 +57,13 @@ clnt_create (const char *hostname, u_long prog, u_long vers,
if (strcmp (proto, "unix") == 0)
{
- memset ((char *)&sun, 0, sizeof (sun));
- sun.sun_family = AF_UNIX;
- strcpy (sun.sun_path, hostname);
+ if (__sockaddr_un_set (&sun, hostname) < 0)
+ {
+ struct rpc_createerr *ce = &get_rpc_createerr ();
+ ce->cf_stat = RPC_SYSTEMERROR;
+ ce->cf_error.re_errno = errno;
+ return NULL;
+ }
sock = RPC_ANYSOCK;
client = clntunix_create (&sun, prog, vers, &sock, 0, 0);
if (client == NULL)
--
2.34.1
next prev parent reply other threads:[~2022-01-18 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 6:49 [COMMITTED 2.33 1/3] socket: Add the __sockaddr_un_set function Aurelien Jarno
2022-01-18 6:49 ` Aurelien Jarno [this message]
2022-01-18 6:49 ` [COMMITTED 2.33 3/3] sunrpc: Test case for clnt_create "unix" buffer overflow (bug 22542) Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118064926.1160592-2-aurelien@aurel32.net \
--to=aurelien@aurel32.net \
--cc=fweimer@redhat.com \
--cc=libc-stable@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).