From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 637C0385840F; Mon, 15 Aug 2022 22:17:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 637C0385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=z/Y19NDDyMWAyZgervB3gqGJxit23Jhb/TsImtwpb4M=; b=YvniUyy9sNebhp0Pt4zBurK7km L8rGJujTcRxBaPXY24tzmaAHu+nwR5/0OkVBYAurgljvkKdTN+BAB7zgzUJC23aCTDys6RteYX1fR Z+GrbOJbB+fyOHmVRK74/BnVt04y9QCU/PsbuZzr2IB9mVysU4TJ//fd0sesotIPhHAeg3q+6RLnj 4VJn97rSoeAplf4RZlmlk0S+SXwx8MpxyDBjmvOsVQipfCve46+KfB4Dh58V5L24haxxKWsjQyJd+ irNPxKwL4FSgZrk0X7LvQmXnjJTrAKwaPh1tnabRmP/nMKSm/GnttMqYIDT6FlCjVPIdONppxkYtm CwT+tWyA==; Received: from [2a01:e0a:406:7381:12d4:684f:f4be:978c] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oNiOx-008oWO-E5; Tue, 16 Aug 2022 00:17:39 +0200 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.96) (envelope-from ) id 1oNiOr-00AQwo-0v; Tue, 16 Aug 2022 00:17:33 +0200 From: Aurelien Jarno To: libc-stable@sourceware.org Cc: Noah Goldstein , Siddhesh Poyarekar Subject: [COMMITTED 2.34 2/2] stdlib: Fixup mbstowcs NULL __dst handling. [BZ #29279] Date: Tue, 16 Aug 2022 00:17:08 +0200 Message-Id: <20220815221707.2475899-2-aurelien@aurel32.net> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220815221707.2475899-1-aurelien@aurel32.net> References: <20220815221707.2475899-1-aurelien@aurel32.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 22:17:43 -0000 From: Noah Goldstein commit 464d189b9622932a75302290625de84931656ec0 (origin/master, origin/HEAD) Author: Noah Goldstein Date: Wed Jun 22 08:24:21 2022 -0700 stdlib: Remove attr_write from mbstows if dst is NULL [BZ: 29265] Incorrectly called `__mbstowcs_chk` in the NULL __dst case which is incorrect as in the NULL __dst case we are explicitly skipping the objsize checks. As well, remove the `__always_inline` attribute which exists in `__fortify_function`. Reviewed-by: Siddhesh Poyarekar (cherry picked from commit 220b83d83d32aa9e6f5659e2fa2a63a0024c3e4a) --- stdlib/bits/stdlib.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/stdlib/bits/stdlib.h b/stdlib/bits/stdlib.h index f0918d5d79..ac9badc81f 100644 --- a/stdlib/bits/stdlib.h +++ b/stdlib/bits/stdlib.h @@ -96,10 +96,10 @@ extern size_t __mbstowcs_chk (wchar_t *__restrict __dst, const char *__restrict __src, size_t __len, size_t __dstlen) __THROW __attr_access ((__write_only__, 1, 3)) __attr_access ((__read_only__, 2)); -extern size_t __REDIRECT_NTH (__mbstowcs_chk_nulldst, +extern size_t __REDIRECT_NTH (__mbstowcs_nulldst, (wchar_t *__restrict __dst, const char *__restrict __src, - size_t __len), mbstowcs_chk) + size_t __len), mbstowcs) __attr_access ((__read_only__, 2)); extern size_t __REDIRECT_NTH (__mbstowcs_alias, (wchar_t *__restrict __dst, @@ -113,12 +113,12 @@ extern size_t __REDIRECT_NTH (__mbstowcs_chk_warn, __warnattr ("mbstowcs called with dst buffer smaller than len " "* sizeof (wchar_t)"); -__always_inline __fortify_function size_t +__fortify_function size_t __NTH (mbstowcs (wchar_t *__restrict __dst, const char *__restrict __src, size_t __len)) { if (__builtin_constant_p (__dst == NULL) && __dst == NULL) - return __mbstowcs_chk_nulldst (__dst, __src, __len); + return __mbstowcs_nulldst (__dst, __src, __len); else return __glibc_fortify_n (mbstowcs, __len, sizeof (wchar_t), __glibc_objsize (__dst), __dst, __src, __len); -- 2.35.1