From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 38761385841F for ; Tue, 3 Oct 2023 17:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38761385841F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C57004136A; Tue, 3 Oct 2023 17:08:45 +0000 (UTC) Received: from pdx1-sub0-mail-a208.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 66DC14165C; Tue, 3 Oct 2023 17:08:45 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696352925; a=rsa-sha256; cv=none; b=RFLktokHxIHTqhqUrCekch3TRDlaTqHfNqjYXDXUW2hYIzztKurMLp5KUioWVd66DtzBFB kbIJrRwiSLsafmb2NxZ7sQF+GeWG87UxI1iP/uaMLn3DE3UI6bjaPST45i8xzEFrBt0RMu 6MzyBq0gIat0PdU651y5dKOL27/G+TyyeqlfSwgyYe3KZSwu7YOSd7SfeGzODuZMnDw/qy GMIPDvE6BVMdpfcP7Umgt1U7Nmm4BUGkl7AYo0hEet2WN+GHePAXyOWO8YaOGIIZIV/IZj NpTdso2xx2ToK038oFp+0lCrSb3DKSgWAoNMFGJ1O4BdFwCr9N4VUwXG4mwuCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696352925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PrsyM6wf3aTNDKzCPXYYUYB0wug3WMHxGgVBm1YZqaI=; b=9Tvc5dTzUOEn+I11u+4DHME5VUsBZ7bthNFHKVr9kC1onG8pVfNTL5UPk/ZTxv6/LixnQU GuGcZscSgSzDAh/fJLFPLSvky0FqfP9dcNh5tvmy6UYPgAMo6WN7zQN7WqDNfSCSJ00fOV jeQ7sS16IQZgGWWeqkWvGbl7ecw3dXkPGsE3LVW7zieVDj4SAbbrIlePy+dD3720Uj34LI 3+qUJj7BJ8P6N9cjQ4jGnjg1Cv4K8Npwk92dM+p8gCoBpOpuu1ao4+9B3396b78CEkysFo r/fju+Q94Jn6jfMABK1hm2ehfAhji4n/MGSWuzRh44kNwxqw0hy3Tah/v2CArQ== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-cwg48; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MC-Copy: stored-urls X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shade-Drop: 62fe2caa44e97819_1696352925641_3718423960 X-MC-Loop-Signature: 1696352925641:1943896625 X-MC-Ingress-Time: 1696352925641 Received: from pdx1-sub0-mail-a208.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.191.212 (trex/6.9.1); Tue, 03 Oct 2023 17:08:45 +0000 Received: from fedora.redhat.com (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a208.dreamhost.com (Postfix) with ESMTPSA id 4S0PRd0N3vzDY; Tue, 3 Oct 2023 10:08:44 -0700 (PDT) From: Siddhesh Poyarekar To: libc-stable@sourceware.org Cc: Carlos O'Donell Subject: [committed 2.38 1/2] Propagate GLIBC_TUNABLES in setxid binaries Date: Tue, 3 Oct 2023 13:08:32 -0400 Message-ID: <20231003170837.64992-2-siddhesh@sourceware.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231003170837.64992-1-siddhesh@sourceware.org> References: <20231003170837.64992-1-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1172.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: GLIBC_TUNABLES scrubbing happens earlier than envvar scrubbing and some tunables are required to propagate past setxid boundary, like their env_alias. Rely on tunable scrubbing to clean out GLIBC_TUNABLES like before, restoring behaviour in glibc 2.37 and earlier. Signed-off-by: Siddhesh Poyarekar Reviewed-by: Carlos O'Donell (cherry picked from commit 0d5f9ea97f1b39f2a855756078771673a68497e1) --- sysdeps/generic/unsecvars.h | 1 - 1 file changed, 1 deletion(-) diff --git a/sysdeps/generic/unsecvars.h b/sysdeps/generic/unsecvars.h index 81397fb90b..8278c50a84 100644 --- a/sysdeps/generic/unsecvars.h +++ b/sysdeps/generic/unsecvars.h @@ -4,7 +4,6 @@ #define UNSECURE_ENVVARS \ "GCONV_PATH\0" \ "GETCONF_DIR\0" \ - "GLIBC_TUNABLES\0" \ "HOSTALIASES\0" \ "LD_AUDIT\0" \ "LD_DEBUG\0" \ -- 2.41.0