From: Sam James <sam@gentoo.org>
To: libc-stable@sourceware.org
Cc: Gabi Falk <gabifalk@gmx.com>, "H . J . Lu" <hjl.tools@gmail.com>,
"Dmitry V . Levin" <ldv@altlinux.org>
Subject: [COMMITTED 2.39 3/3] Add a test to check for duplicate definitions in the static library
Date: Sat, 4 May 2024 13:26:06 +0100 [thread overview]
Message-ID: <20240504122607.2559911-3-sam@gentoo.org> (raw)
In-Reply-To: <20240504122607.2559911-1-sam@gentoo.org>
From: Gabi Falk <gabifalk@gmx.com>
This change follows two previous fixes addressing multiple definitions
of __memcpy_chk and __mempcpy_chk functions on i586, and __memmove_chk
and __memset_chk functions on i686. The test is intended to prevent
such issues from occurring in the future.
Signed-off-by: Gabi Falk <gabifalk@gmx.com>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
(cherry picked from commit ded2e0753e9c46debeb2e0d26c5e560d2581d314)
---
Makefile | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Makefile b/Makefile
index 7052b46df8..2e351c0321 100644
--- a/Makefile
+++ b/Makefile
@@ -577,6 +577,13 @@ $(objpfx)lint-makefiles.out: scripts/lint-makefiles.sh
$(SHELL) $< "$(PYTHON)" `pwd` > $@ ; \
$(evaluate-test)
+# Link libc.a as a whole to verify that it does not contain multiple
+# definitions of any symbols.
+tests-special += $(objpfx)link-static-libc.out
+$(objpfx)link-static-libc.out:
+ $(LINK.o) $(whole-archive) -r $(objpfx)libc.a -o /dev/null > $@ 2>&1; \
+ $(evaluate-test)
+
# Print test summary for tests in $1 .sum file;
# $2 is optional test identifier.
# Fail if there are unexpected failures in the test results.
--
2.45.0
prev parent reply other threads:[~2024-05-04 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 12:26 [COMMITTED 2.39 1/3] i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk Sam James
2024-05-04 12:26 ` [COMMITTED 2.39 2/3] i686: Fix multiple definitions of __memmove_chk and __memset_chk Sam James
2024-05-04 12:26 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504122607.2559911-3-sam@gentoo.org \
--to=sam@gentoo.org \
--cc=gabifalk@gmx.com \
--cc=hjl.tools@gmail.com \
--cc=ldv@altlinux.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).