From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88784 invoked by alias); 27 Nov 2019 11:56:08 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 88773 invoked by uid 89); 27 Nov 2019 11:56:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*libc-stable, HX-Languages-Length:1570, H*i:sk:4d03632, H*f:sk:4d03632 X-Spam-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 11:56:07 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xARBqFuU043741 for ; Wed, 27 Nov 2019 06:56:05 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2whh8s75r3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Nov 2019 06:56:05 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Nov 2019 11:56:03 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Nov 2019 11:56:02 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xARBu2kI54722632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Nov 2019 11:56:02 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED7A642047; Wed, 27 Nov 2019 11:56:01 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0CB442041; Wed, 27 Nov 2019 11:56:01 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.152.222.34]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 27 Nov 2019 11:56:01 +0000 (GMT) Subject: [2.30 COMMITTED] S390: Fix handling of needles crossing a page in strstr z15 ifunc-variant. [BZ #25226] To: libc-stable@sourceware.org References: <56bab444-9d67-c9a3-6117-c8a94d024075@linux.ibm.com> <8736e9hde8.fsf@oldenburg2.str.redhat.com> <4d03632f-1339-2e81-2418-18a6e0b31b8d@linux.ibm.com> Cc: libc-alpha@sourceware.org From: Stefan Liebler Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <4d03632f-1339-2e81-2418-18a6e0b31b8d@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19112711-0008-0000-0000-00000338E8BD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19112711-0009-0000-0000-00004A57F0BC Message-Id: <32472cf3-4e0b-2835-c8e9-b289219e4785@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-27_02:2019-11-27,2019-11-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 clxscore=1011 priorityscore=1501 impostorscore=0 malwarescore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911270104 X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00032.txt.bz2 On 11/27/19 12:53 PM, Stefan Liebler wrote: > On 11/27/19 10:33 AM, Florian Weimer wrote: >> * Stefan Liebler: >> >>> if the specified needle crosses a page-boundary, the s390-z15 ifunc >>> variant of strstr truncates the needle which results in invalid >>> results. >>> >>> This is fixed by loading the needle beyond the page boundary to v18 >>> instead of v16. The bug is sometimes observable in test-strstr.c in >>> check1() and check2() as the haystack and needle is stored on >>> stack. Thus the needle can be on a page boundary. >> >> (GNU style is “check1 and check2”, no parentheses.) >> >>> check2 is now extended to test haystack / needles located on stack, at >>> end of page and on two pages. >> >> The test change looks okay to me.  I haven't reviewed the assembler >> change.  I think you can commit that as the architecture maintainer. >> >> We will need help from your team with testing the downstream fix.  Do >> you think we should fix this proactively in Red Hat Enterprise Linux 8.1 >> as well?  It received the backport of the new strstr implementation, >> too. >> >> Thanks, >> Florian >> > > Committed it with “check1 and check2” and a reference to the commit > 6f47401bd5fc71209219779a0426170a9a7395b0. > > Regarding RHEL, I've recognized that you've opened a RHEL Bugzilla and > answered there. > > Thanks, > Stefan > I've just committed https://sourceware.org/git/?p=glibc.git;a=commit;h=f4419b0d0181da28f18cba40068f2e75300f5020