public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
From: Rafal Luzynski <digitalfreak@lingonborough.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: libc-stable@sourceware.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [2.29 COMMITTED] regex: fix read overrun [BZ #24114]
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <342967710.135789.1553033852674@poczta.nazwa.pl> (raw)
In-Reply-To: <20190319120322.GA28833@aurel32.net>

19.03.2019 13:03 Aurelien Jarno <aurelien@aurel32.net> wrote:
> [...]
> In practice looking at the glibc 2.28 branch (the 2.29 has very few
> commit, and most of them backported immediately after being committed to
> the master branch), it appears that both practices are common. I have
> attached a patch fixing the commit dates to give an example of the
> impact.

Now I have looked at ChangeLog in 2.28 and I agree with you.  The dates
look pretty random and nobody complains.  I am not going to be the only
one who complains, this really does not hurt me.  I only (wrongly) thought
this was required.

In case of 2.29, as you said, there are few commits after the release
so we may fix the dates or just ignore, if nobody cares.

> I think we should just decide a rule, fix the wrong entries if needed,
> and apply it to new commits. On my side I am undecided what is the best
> option.

I am undecided as well but I will not ask for an additional work for
maintainers if nobody needs this.

> [1]
> https://sourceware.org/glibc/wiki/GlibcGit?Cherry_Pick_Changes_From_Another_Branch

Thanks for this link, by the way.

Regards,

Rafal

  reply	other threads:[~2019-03-19 22:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 Aurelien Jarno
2019-01-01  0:00 ` [2.29 COMMITTED] Record CVE-2019-9169 in NEWS and ChangeLog " Aurelien Jarno
2019-01-01  0:00 ` [2.29 COMMITTED] regex: fix read overrun " Rafal Luzynski
2019-01-01  0:00   ` Florian Weimer
2019-01-01  0:00     ` Rafal Luzynski
2019-01-01  0:00       ` Florian Weimer
2019-01-01  0:00   ` Aurelien Jarno
2019-01-01  0:00     ` Rafal Luzynski [this message]
2019-01-01  0:00   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=342967710.135789.1553033852674@poczta.nazwa.pl \
    --to=digitalfreak@lingonborough.com \
    --cc=aurelien@aurel32.net \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-stable@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).