public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
* please backport "Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]"
@ 2022-11-06 18:04 Andreas K. Huettel
  0 siblings, 0 replies; only message in thread
From: Andreas K. Huettel @ 2022-11-06 18:04 UTC (permalink / raw)
  To: libc-stable

[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]

Now that make-4.4 has been released, it would probably be a good idea to backport
this commit from master to the release branches as well... I don't have the perms
but if someone else could do it...

(We're already using it in Gentoo.)

Thanks.

commit 2d7ed98add14f75041499ac189696c9bd3d757fe
Author:     Sergei Trofimovich <slyich@gmail.com>
AuthorDate: Tue Sep 13 13:39:13 2022 -0400
Commit:     Siddhesh Poyarekar <siddhesh@sourceware.org>
CommitDate: Tue Sep 13 13:45:32 2022 -0400

    Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]
    
    make-4.4 will add long flags to MAKEFLAGS variable:
    
        * WARNING: Backward-incompatibility!
          Previously only simple (one-letter) options were added to the MAKEFLAGS
          variable that was visible while parsing makefiles.  Now, all options
          are available in MAKEFLAGS.
    
    This causes locale builds to fail when long options are used:
    
        $ make --shuffle
        ...
        make  -C localedata install-locales
        make: invalid shuffle mode: '1662724426r'
    
    The change fixes it by passing eash option via whitespace and dashes.
    That way option is appended to both single-word form and whitespace
    separated form.
    
    While at it fixed --silent mode detection in $(MAKEFLAGS) by filtering
    out --long-options. Otherwise options like --shuffle flag enable silent
    mode unintentionally. $(silent-make) variable consolidates the checks.
    
    Resolves: BZ# 29564
    
    CC: Paul Smith <psmith@gnu.org>
    CC: Siddhesh Poyarekar <siddhesh@gotplt.org>
    Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

 Makeconfig     | 18 +++++++++++++++++-
 Makerules      |  4 ++--
 elf/rtld-Rules |  2 +-
 3 files changed, 20 insertions(+), 4 deletions(-)


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-06 18:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 18:04 please backport "Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]" Andreas K. Huettel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).