From: "Miguel Martín" <mmartinv@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
Miguel Martin via Libc-stable <libc-stable@sourceware.org>
Subject: Re: [COMMITTED 2.34 0/2] Improve aligned_alloc and calloc test coverage
Date: Tue, 21 May 2024 14:12:32 +0200 [thread overview]
Message-ID: <8242e6f82e34b9a9dd991972285bc3ddf337d7d8.camel@redhat.com> (raw)
In-Reply-To: <87v8375ttx.fsf@oldenburg.str.redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Tue, 2024-05-21 at 12:43 +0200, Florian Weimer wrote:
> * Miguel Martin via Libc-stable:
>
> > From: Miguel Martín <mmartinv@redhat.com>
> >
> > Backports to improve aligned_alloc and calloc test coverage in
> > glibc 2.34:
> >
> > DJ Delorie (1):
> > aligned_alloc: conform to C17
> >
> > Joe Simmons-Talbott (1):
> > malloc: Improve aligned_alloc and calloc test coverage.
>
> As far as I can see, none of these patches have actually been
> committed
> (pushed to the official repository).
>
> Thanks,
> Florian
>
Both are in master and the first one has been already backported to
release/2.39/master:
git branch --contains d1417176a35d27ffb8da0ffb1e33154163b6eeb2
master
release/2.39/master
git show -s d1417176a35d27ffb8da0ffb1e33154163b6eeb2
commit d1417176a35d27ffb8da0ffb1e33154163b6eeb2
Author: DJ Delorie <dj@redhat.com>
Date: Tue Mar 21 00:46:43 2023 -0400
aligned_alloc: conform to C17
This patch adds the strict checking for power-of-two alignments
in aligned_alloc(), and updates the manual accordingly.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
git branch --contains 3395157ff2b0657d70c36169156f67440205c8bf
master
git show -s 3395157ff2b0657d70c36169156f67440205c8bf
commit 3395157ff2b0657d70c36169156f67440205c8bf
Author: Joe Simmons-Talbott <josimmon@redhat.com>
Date: Tue May 14 14:36:50 2024 +0000
malloc: Improve aligned_alloc and calloc test coverage.
Add a DSO (malloc/tst-aligned_alloc-lib.so) that can be used during
testing to interpose malloc with a call that randomly uses either
aligned_alloc, __libc_malloc, or __libc_calloc in the place of
malloc.
Use LD_PRELOAD with the DSO to mirror malloc/tst-malloc.c testing
as an
example in malloc/tst-malloc-random.c. Add malloc/tst-aligned-
alloc-random.c
as another example that does a number of malloc calls with randomly
sized,
but limited to 0xffff, requests.
The intention is to be able to utilize existing malloc testing to
ensure
that similar allocation APIs are also exposed to the same rigors.
Reviewed-by: DJ Delorie <dj@redhat.com>
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEERBNxlsW9fRmqDQAeOZwMQZdKxwAFAmZMj7AACgkQOZwMQZdK
xwCFPQ/+P7d92EAhd0zfAUrb1Xhl5FUralxIwgyHVi2c1Q0/Ty7bg0cKboVxio9S
V8qWF3PgoMIGP+X1Az4eJ5Gyif54Kv0D03PEh6m1SeUWF9iuNRqUfdPfuBahBLRN
NsMxjjdJDByp+R6wIQgUcDQyJUMe1RHmwev2rReVVTfWbN/Igc+tMqSv6wkFeEdJ
OWjXRUDN7PGF8NW+nkQ75AKFE6gIfxKWLfcFEy4m5FRaio9xc2i4koAo6a5eS3pv
NIdwPdMaF21q9dO8lBTMaF8Gy/Pak81SC1Nq3yUPBPoJ8Wg2cr2ZiYez1Dc2gi+A
iekKN6MsUgy8QJMXYFneS5rKN4TUw7ynzRABX+hVD1xy9QPkXa1qpYRsH0Aihg0l
BN785LLdlmzYrTICT/5Ep9R8Swv5l7yYYt5+8LLVdJcBl5XqI46Lxf2RysrmFJ4D
DxCcg2Ybz51+DFRFmgS8Gb6HsnuFx6nwxDart+9DcH6LtLJu9Gf2E5kiEVoG2/ME
hUDMC/zJQ9m/cw0Ffs32URe/6RBB/c1V2mmKflo+pj/yCsAsA+ZxCoefXYH2z4cp
UakwMlDhm/trfF0Zug4jSIh2Rb4pVYDRkG5r43g9DZAWC1/L/fsGVRb4fPrPwTrA
T+wbOKtbcvKtVzk7qcncqBqAJDz0hxpkoApPweUZ3WvHCn1aOVk=
=DXW+
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2024-05-21 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 8:38 Miguel Martin
2024-05-21 8:38 ` [COMMITTED 2.34 1/2] aligned_alloc: conform to C17 Miguel Martin
2024-05-21 8:38 ` [COMMITTED 2.34 2/2] malloc: Improve aligned_alloc and calloc test coverage Miguel Martin
2024-05-21 10:42 ` Florian Weimer
2024-05-21 13:00 ` Miguel Martín
2024-05-21 13:06 ` Adhemerval Zanella Netto
2024-05-21 13:30 ` Miguel Martín
2024-05-21 13:32 ` Sam James
2024-05-21 13:24 ` Florian Weimer
2024-05-21 10:43 ` [COMMITTED 2.34 0/2] " Florian Weimer
2024-05-21 12:12 ` Miguel Martín [this message]
2024-05-21 12:51 ` Miguel Martín
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8242e6f82e34b9a9dd991972285bc3ddf337d7d8.camel@redhat.com \
--to=mmartinv@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).