From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B6A003858426 for ; Sat, 13 Apr 2024 18:22:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6A003858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6A003858426 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713032550; cv=none; b=YRrkIbHyx9jj4nqBH0eCDwVb+Vj7fKnaLkiQ5EjWNT7I303twihI6GLcWQJI1i7Sx3RAPQpN6DP9lBQ65+LV1u683/suYNJmFVJmosumsrmI8oRIiIpkKwHZ50nYXdFx+fYMd/PDZ8M2bDKDPc6AVUhjOPbxEClj6871QpnDCSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713032550; c=relaxed/simple; bh=WaNjwvvbMT+Q6T5qQw15TXgrMxxfFOCXG75a3uRqE9g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eQI+/mVbzW1CmV0SlxiVIbYpiMauNcy0j5DMxRFk6bdDenu2wqP5b2p16MwjnmZJgkuBzTVAQT1PbwrwLEdfAQrX0dwOSx1oPGTfnnv/RJmnpr9rtyetXsLfkJoOamcrJJ83wwJnFDtw2LXq26GkkUGJdMxQuH5FRU++/r3gOXc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713032548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a0h0O+zcqiSddSRH5r3pDRkmGm1CfkcXaY/Oy290F48=; b=DG+5se4z7xy5gDZnqvdL1qNt/mAF5MylWOP4TEzt4DKdINYdP3lxSUPn2MHGdSuGfOYpS0 d9aHh/Fh2udkQ12rzBWINwybd/hExRo1m/EA+05vqpTrbMEnPrD3DXXn6kxs6hXzZzcC6D UyuvJz9EMdQJxgKDL4+9Q8Dy9byaeR0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-h_QSzE1pMGOtAeEWiiwCcw-1; Sat, 13 Apr 2024 14:22:26 -0400 X-MC-Unique: h_QSzE1pMGOtAeEWiiwCcw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DC8C1C04B5A; Sat, 13 Apr 2024 18:22:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92A1A1121312; Sat, 13 Apr 2024 18:22:25 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: Sunil K Pandey , Libc-stable Mailing List Subject: Re: [PATCH] x86-64: Simplify minimum ISA check ifdef conditional with if In-Reply-To: (H. J. Lu's message of "Sat, 13 Apr 2024 11:04:44 -0700") References: <20240302003843.3333713-1-skpgkp2@gmail.com> <87h6g51773.fsf@oldenburg.str.redhat.com> Date: Sat, 13 Apr 2024 20:22:19 +0200 Message-ID: <87a5lx15t0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: > On Sat, Apr 13, 2024 at 10:52=E2=80=AFAM Florian Weimer wrote: >> >> * H. J. Lu: >> >> > Should it also be backported to glibc 2.39 together with >> > >> > commit befe2d3c4dec8be2cdd01a47132e47bdb7020922 >> > Author: H.J. Lu >> > Date: Wed Feb 28 09:51:14 2024 -0800 >> > >> > x86-64: Don't use SSE resolvers for ISA level 3 or above >> >> This is the one that breaks valgrind, isn't it? > > No. -march=3Dx86-64-v3 triggers the valgrind error in flibc test. This > commit fixes the -march=3Dx86-64-v3 build. > > commit b6e3898194bbae78910bbe9cd086937014961e45 > Author: Sunil K Pandey > Date: Thu Feb 29 17:57:02 2024 -0800 > > x86-64: Simplify minimum ISA check ifdef conditional with if > > updates this commit. Backporting the above commit makes the > backported code look similar to upstream. yes, I was confused, after all I backported the =E2=80=9Cx86-64: Don't use = SSE resolvers for ISA level 3 or above=E2=80=9D commit and saw the valgrind fai= lure with it! I'll run my tests again for the additional backport and push it. Thanks, Florian