From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3B2583858D28 for ; Fri, 19 Aug 2022 11:18:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B2583858D28 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-wiExI3J2OPeSiZpZ7MH03g-1; Fri, 19 Aug 2022 07:18:14 -0400 X-MC-Unique: wiExI3J2OPeSiZpZ7MH03g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 597FD3C02185; Fri, 19 Aug 2022 11:18:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85030C15BBA; Fri, 19 Aug 2022 11:18:13 +0000 (UTC) From: Florian Weimer To: Aurelien Jarno Cc: libc-stable@sourceware.org Subject: Re: Backport /dev/pts to older branches? References: Date: Fri, 19 Aug 2022 13:18:11 +0200 In-Reply-To: (Aurelien Jarno's message of "Fri, 19 Aug 2022 11:39:12 +0200") Message-ID: <87edxc32j0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 11:18:19 -0000 * Aurelien Jarno: > I would be interested in backporting the following change to Debian > Bullseye package: > > commit 27fe5f2e67a0e4cc0526b1b32b55f8e519075edb > Author: Florian Weimer > Date: Wed Oct 7 14:55:04 2020 +0200 > > Linux: Require properly configured /dev/pts for PTYs > > Current systems do not have BSD terminals, so the fallback code in > posix_openpt/getpt does not do anything. Also remove the file system > check for /dev/pts. Current systems always have a devpts file system > mounted there if /dev/ptmx exists. > > grantpt is now essentially a no-op. It only verifies that the > argument is a ptmx-descriptor. Therefore, this change indirectly > addresses bug 24941. > > Reviewed-by: Adhemerval Zanella > > This fixes bz#24941, which seems to affects ansible users. I wonder if I > should backport it in the upstream stable release branch instead. This > is trivial to backport, but on some rare systems, this might require some > changes to get /dev/pts working. We haven't backported it to our downstream 2.28-based glibc (or even earlier), but maybe we should. Not sure why our users aren't getting hit by this regularly. Doing the backport upstream should be okay (along with the NEWS update). Thanks, Florian