From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103383 invoked by alias); 4 Feb 2019 21:00:01 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 103371 invoked by uid 89); 4 Feb 2019 21:00:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=wednesday, firm X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Feb 2019 21:00:00 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F5D67F6B2; Mon, 4 Feb 2019 20:59:59 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-144.ams2.redhat.com [10.36.116.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A16FB17B15; Mon, 4 Feb 2019 20:59:52 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: Aurelien Jarno , libc-stable@sourceware.org Subject: Re: Backporting CVE-2016-10739 References: <20190204134254.GA13816@aurel32.net> <871s4nppu4.fsf@oldenburg2.str.redhat.com> <87r2cno9qq.fsf@oldenburg2.str.redhat.com> <0a9daa70-7ea9-1ebd-8690-04b6ff2acd88@redhat.com> <87munbo8wy.fsf@oldenburg2.str.redhat.com> <47ca567f-7120-19c5-7ed6-c67c9f6306ca@redhat.com> <87y36vmsr9.fsf@oldenburg2.str.redhat.com> <877eefmk3z.fsf@oldenburg2.str.redhat.com> <2e644830-b506-f5b6-e020-99fc9ee9b94f@redhat.com> Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <2e644830-b506-f5b6-e020-99fc9ee9b94f@redhat.com> (Carlos O'Donell's message of "Mon, 4 Feb 2019 14:58:39 -0500") Message-ID: <87h8djl16h.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 04 Feb 2019 20:59:59 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00018.txt.bz2 * Carlos O'Donell: >> Patch below. What do you think? > > This looks good to me, you make direct use of "__attribute__ > ((visibility ("hidden")))" in an exceptional case, and that's fine. > If this becomes less rare for some reason we might want a > libc-symbols.h macro to define something that expresses the intent of > the hidden visibility e.g. attr_dup_sym_hidden. I'm not a firm believer in those macros. The fact that attribute_hidden expanded to nothing at all was quite a surprise to me. I've pushed the last version. Aurelien, I will not be able to do any more backports before Wednesday, so please feel free to take over. Thanks, Florian