From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123440 invoked by alias); 4 Feb 2019 15:44:37 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 123429 invoked by uid 89); 4 Feb 2019 15:44:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Feb 2019 15:44:35 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F686C057E2B; Mon, 4 Feb 2019 15:44:34 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-219.str.redhat.com [10.33.192.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AB7C6EA03; Mon, 4 Feb 2019 15:44:30 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: Aurelien Jarno , libc-stable@sourceware.org Subject: Re: Backporting CVE-2016-10739 References: <20190204134254.GA13816@aurel32.net> <871s4nppu4.fsf@oldenburg2.str.redhat.com> <87r2cno9qq.fsf@oldenburg2.str.redhat.com> <0a9daa70-7ea9-1ebd-8690-04b6ff2acd88@redhat.com> Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <0a9daa70-7ea9-1ebd-8690-04b6ff2acd88@redhat.com> (Carlos O'Donell's message of "Mon, 4 Feb 2019 10:36:28 -0500") Message-ID: <87munbo8wy.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 04 Feb 2019 15:44:34 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00011.txt.bz2 * Carlos O'Donell: >> +#include >> + > > Please add a comment explaining why this is here. You mean like this? /* Obtain the prototype for __inet_aton_exact. */ >> +/* Declare __inet_aton_exact as hidden, so that it does not get >> + exported from nscd. */ >> +__typeof__ (__inet_aton_exact) __inet_aton_exact attribute_hidden; >> + >> +/* Do not provide definitions of the public symbols exported from >> + libc. */ >> +#undef weak_alias >> +#define weak_alias(from, to) >> + >> +#include > > Can we kill the prototype from the public header and use an internal > header? It seems messy to leave that prototype for the GLIBC_PRIVATE > symbol in the public header. It might tempt people to workaround the > linkage protection. I don't understand. There is no public header. We can't remove it from the internal header because it would break the test suite build. Thanks, Florian