* Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
[not found] <20220719051055.76F3A385801D@sourceware.org>
@ 2022-07-19 10:17 ` Florian Weimer
2022-07-19 15:55 ` Sunil Pandey
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2022-07-19 10:17 UTC (permalink / raw)
To: Sunil K Pandey; +Cc: libc-stable, H.J. Lu
* Sunil Pandey via Glibc-cvs:
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010
>
> commit f6bc52f080e4a0195c707c01f54e2eae0ff89010
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Fri May 20 19:21:48 2022 -0700
>
> x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
>
> According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
> and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we
> can ignore their r_addends.
>
> Reviewed-by: Fangrui Song <maskray@google.com>
> (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084)
Do we really need to backport this? It seems a bit risky.
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
2022-07-19 10:17 ` [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT Florian Weimer
@ 2022-07-19 15:55 ` Sunil Pandey
2022-07-19 17:51 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Sunil Pandey @ 2022-07-19 15:55 UTC (permalink / raw)
To: Florian Weimer; +Cc: Libc-stable Mailing List, H.J. Lu
On Tue, Jul 19, 2022 at 3:17 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Sunil Pandey via Glibc-cvs:
>
> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010
> >
> > commit f6bc52f080e4a0195c707c01f54e2eae0ff89010
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Fri May 20 19:21:48 2022 -0700
> >
> > x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
> >
> > According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
> > and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we
> > can ignore their r_addends.
> >
> > Reviewed-by: Fangrui Song <maskray@google.com>
> > (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084)
>
> Do we really need to backport this? It seems a bit risky.
>
> Thanks,
> Florian
>
Hi Florian,
This backport is already pushed to 2.35, 2.34 and 2.33.
Should I revert this commit from 2.34 and 2.33?
Thanks,
Sunil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
2022-07-19 15:55 ` Sunil Pandey
@ 2022-07-19 17:51 ` Florian Weimer
0 siblings, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2022-07-19 17:51 UTC (permalink / raw)
To: Sunil Pandey via Libc-stable; +Cc: Sunil Pandey
* Sunil Pandey via Libc-stable:
> On Tue, Jul 19, 2022 at 3:17 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * Sunil Pandey via Glibc-cvs:
>>
>> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010
>> >
>> > commit f6bc52f080e4a0195c707c01f54e2eae0ff89010
>> > Author: H.J. Lu <hjl.tools@gmail.com>
>> > Date: Fri May 20 19:21:48 2022 -0700
>> >
>> > x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
>> >
>> > According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
>> > and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we
>> > can ignore their r_addends.
>> >
>> > Reviewed-by: Fangrui Song <maskray@google.com>
>> > (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084)
>>
>> Do we really need to backport this? It seems a bit risky.
>>
>> Thanks,
>> Florian
>>
>
> Hi Florian,
>
> This backport is already pushed to 2.35, 2.34 and 2.33.
>
> Should I revert this commit from 2.34 and 2.33?
If it was included by mistake, yes please. I was just wondering if
there was a compelling reason to include it that I had missed.
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-19 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220719051055.76F3A385801D@sourceware.org>
2022-07-19 10:17 ` [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT Florian Weimer
2022-07-19 15:55 ` Sunil Pandey
2022-07-19 17:51 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).