From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 285043858291
 for <libc-stable@sourceware.org>; Tue, 19 Jul 2022 10:17:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 285043858291
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-63-qGzMTfwiMqaAByuOb-cZQQ-1; Tue, 19 Jul 2022 06:17:06 -0400
X-MC-Unique: qGzMTfwiMqaAByuOb-cZQQ-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B32D6801755;
 Tue, 19 Jul 2022 10:17:05 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.173])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C17651121314;
 Tue, 19 Jul 2022 10:17:04 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Sunil K Pandey <skpgkp2@gmail.com>
Cc: libc-stable@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for
 R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
References: <20220719051055.76F3A385801D@sourceware.org>
Date: Tue, 19 Jul 2022 12:17:00 +0200
In-Reply-To: <20220719051055.76F3A385801D@sourceware.org> (Sunil Pandey via
 Glibc-cvs's message of "Tue, 19 Jul 2022 05:10:55 +0000 (GMT)")
Message-ID: <87pmi18l0j.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-stable@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-stable mailing list <libc-stable.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-stable/>
List-Help: <mailto:libc-stable-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jul 2022 10:17:10 -0000

* Sunil Pandey via Glibc-cvs:

> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010
>
> commit f6bc52f080e4a0195c707c01f54e2eae0ff89010
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Fri May 20 19:21:48 2022 -0700
>
>     x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
>     
>     According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
>     and R_X86_64_JUMP_SLOT.  Since linkers always set their r_addends to 0, we
>     can ignore their r_addends.
>     
>     Reviewed-by: Fangrui Song <maskray@google.com>
>     (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084)

Do we really need to backport this?  It seems a bit risky.

Thanks,
Florian