From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9DD1A38582AB for ; Tue, 10 Jan 2023 19:41:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DD1A38582AB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673379665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IKsl35GC+Eu6HXJxWdZp4/jw5qzf1DyTjCNicpA+5ak=; b=XK//QVKL0cT8wceLeIomH1ffIwQtKnqdNvu0LDUdv+v+iJxQKEE/MuS49YYF6XrO90mBIw fAhWyCQ1GNfc7xtB4l2aczjVG7EZtEJjD7ATd5/mH1S8Pp7scQPPD2e6lhkuLvU+fuVNbw SjT53hV0TypApSN8scsQhDLF5YmY5ng= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-t-4aXHCwP22dROlFM_FtFA-1; Tue, 10 Jan 2023 14:41:04 -0500 X-MC-Unique: t-4aXHCwP22dROlFM_FtFA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8FE33811F20 for ; Tue, 10 Jan 2023 19:41:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47F321121314 for ; Tue, 10 Jan 2023 19:41:03 +0000 (UTC) From: Florian Weimer To: libc-stable@sourceware.org Subject: Re: [glibc/release/2.34/master] elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205] References: <20230110193732.3F51E3858416@sourceware.org> Date: Tue, 10 Jan 2023 20:41:01 +0100 In-Reply-To: <20230110193732.3F51E3858416@sourceware.org> (Florian Weimer via Glibc-cvs's message of "Tue, 10 Jan 2023 19:37:32 +0000 (GMT)") Message-ID: <87r0w2dvoy.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Florian Weimer via Glibc-cvs: > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bbe4bbb6e8997b5ff9843bd3f32ac77dbaec7284 > > commit bbe4bbb6e8997b5ff9843bd3f32ac77dbaec7284 > Author: Fangrui Song > Date: Mon Aug 16 09:59:30 2021 -0700 > > elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205] > > elf/tls-macros.h was added for TLS testing when GCC did not support > __thread. __thread and tls_model attributes are mature now and have been > used by many newer tests. > > Also delete tst-tls2.c which tests .tls_common (unused by modern GCC and > unsupported by Clang/LLD). .tls_common and .tbss definition are almost > identical after linking, so the runtime test doesn't add additional > coverage. Assembler and linker tests should be on the binutils side. > > When LLD 13.0.0 is allowed in configure.ac > (https://sourceware.org/pipermail/libc-alpha/2021-August/129866.html), > `make check` result is on par with glibc built with GNU ld on aarch64 > and x86_64. > > As a future clean-up, TLS_GD/TLS_LD/TLS_IE/TLS_IE macros can be removed from > sysdeps/*/tls-macros.h. We can add optional -mtls-dialect={gnu2,trad} > tests to ensure coverage. > > Tested on aarch64-linux-gnu, powerpc64le-linux-gnu, and x86_64-linux-gnu. > > Reviewed-by: Szabolcs Nagy > (cherry picked from commit 33c50ef42878b07ee6ead8b3f1a81d8c2c74697c) I backported this because it fixes many TLS test failures when building powerpc64le-linux-gnu with with -mcpu=power10. Together with: commit d0e2ac0c5902bd0e671863cc6cb14024d0365e67 Author: Alan Modra Date: Sat Nov 12 11:20:31 2022 +1030 elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 (BZ# 29776) Supports pcrel addressing of TLS GOT entry. Also tweak the non-pcrel asm constraint to better reflect how the reg is used. (cherry picked from commit 94628de77888c3292fc103840731ff85f283368e) the test suite is now clean. Thanks, Florian