From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 97AB93858C83 for ; Tue, 19 Jul 2022 17:51:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97AB93858C83 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-Pwc6R_ZbM5-1nw2zqjsVBw-1; Tue, 19 Jul 2022 13:51:32 -0400 X-MC-Unique: Pwc6R_ZbM5-1nw2zqjsVBw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB4313C138A2; Tue, 19 Jul 2022 17:51:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B5DB141511A; Tue, 19 Jul 2022 17:51:31 +0000 (UTC) From: Florian Weimer To: Sunil Pandey via Libc-stable Cc: Sunil Pandey Subject: Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT References: <20220719051055.76F3A385801D@sourceware.org> <87pmi18l0j.fsf@oldenburg.str.redhat.com> Date: Tue, 19 Jul 2022 19:51:30 +0200 In-Reply-To: (Sunil Pandey via Libc-stable's message of "Tue, 19 Jul 2022 08:55:40 -0700") Message-ID: <87tu7d6lel.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 17:51:34 -0000 * Sunil Pandey via Libc-stable: > On Tue, Jul 19, 2022 at 3:17 AM Florian Weimer wrote: >> >> * Sunil Pandey via Glibc-cvs: >> >> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010 >> > >> > commit f6bc52f080e4a0195c707c01f54e2eae0ff89010 >> > Author: H.J. Lu >> > Date: Fri May 20 19:21:48 2022 -0700 >> > >> > x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT >> > >> > According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT >> > and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we >> > can ignore their r_addends. >> > >> > Reviewed-by: Fangrui Song >> > (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084) >> >> Do we really need to backport this? It seems a bit risky. >> >> Thanks, >> Florian >> > > Hi Florian, > > This backport is already pushed to 2.35, 2.34 and 2.33. > > Should I revert this commit from 2.34 and 2.33? If it was included by mistake, yes please. I was just wondering if there was a compelling reason to include it that I had missed. Thanks, Florian