From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6126 invoked by alias); 13 Apr 2018 18:31:49 -0000 Mailing-List: contact libc-stable-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Archive: Sender: libc-stable-owner@sourceware.org Received: (qmail 1904 invoked by uid 89); 13 Apr 2018 18:31:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=22320, Hx-languages-length:1455, wrongly X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Apr 2018 18:31:41 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3DIU4SY120680 for ; Fri, 13 Apr 2018 14:31:39 -0400 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0b-001b2d01.pphosted.com with ESMTP id 2haya27bwn-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 13 Apr 2018 14:31:38 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Apr 2018 12:31:37 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 13 Apr 2018 12:31:34 -0600 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3DIVYpl66977908; Fri, 13 Apr 2018 11:31:34 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4E267BE03A; Fri, 13 Apr 2018 12:31:34 -0600 (MDT) Received: from shinano (unknown [9.85.146.201]) by b03ledav005.gho.boulder.ibm.com (Postfix) with SMTP id 084D8BE039; Fri, 13 Apr 2018 12:31:31 -0600 (MDT) Received: by shinano (sSMTP sendmail emulation); Fri, 13 Apr 2018 15:31:30 -0300 From: Tulio Magno Quites Machado Filho To: Raphael Moreira Zinsly Cc: libc-stable@sourceware.org, carlos@redhat.com, arjun.is@lostca.se Cc: Subject: Re: [PATCH 2.22] posix: Sync glob with gnulib [BZ #1062] In-Reply-To: <1523558235-30943-1-git-send-email-rzinsly@linux.vnet.ibm.com> References: <873708ks45.fsf@linux.ibm.com> <1523558235-30943-1-git-send-email-rzinsly@linux.vnet.ibm.com> User-Agent: Notmuch/0.25 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu) Date: Mon, 01 Jan 2018 00:00:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18041318-0028-0000-0000-00000971460E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008851; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01017412; UDB=6.00518895; IPR=6.00796649; MB=3.00020562; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-13 18:31:36 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041318-0029-0000-0000-00003A5CFCFF Message-Id: <87vacvhsal.fsf@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-13_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804130170 X-SW-Source: 2018-04/txt/msg00009.txt.bz2 Raphael Moreira Zinsly writes: > This patch syncs posix/glob.c implementation with gnulib version > b5ec983 (glob: simplify symlink detection). The only difference > to gnulib code is > > * DT_UNKNOWN, DT_DIR, and DT_LNK definition in the case there > were not already defined. Gnulib code which uses > HAVE_STRUCT_DIRENT_D_TYPE will redefine them wrongly because > GLIBC does not define HAVE_STRUCT_DIRENT_D_TYPE. Instead > the patch check for each definition instead. > > Also, the patch requires additional globfree and globfree64 files > for compatibility version on some architectures. Also the code > simplification leads to not macro simplification (not need for > NO_GLOB_PATTERN_P anymore). > > Checked on x86_64-linux-gnu and on a build using build-many-glibcs.py > for all major architectures. LGTM. With this patch, I could merge the following patches: [PATCH 2.22 02/14] CVE-2017-15670: glob: Fix one-byte overflow [BZ #22320] [PATCH 2.22 03/14] glob: Add new test tst-glob-tilde [PATCH 2.22 05/14] glob: Fix buffer overflow during GLOB_TILDE unescaping [BZ #22332] If there are any objections, I plan to merge it next Tuesday. After merging these patches, the following patch would still be pending from your initial submission: [PATCH 2.22 11/14] linux: make getcwd(3) fail if it cannot obtain an absolute path [BZ #22679] Thanks! -- Tulio Magno