From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CD45385801C for ; Tue, 18 Jan 2022 07:30:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CD45385801C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-446-7WLY2vXDNV-lHMYwBDJZlQ-1; Tue, 18 Jan 2022 02:30:24 -0500 X-MC-Unique: 7WLY2vXDNV-lHMYwBDJZlQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79BE01018720; Tue, 18 Jan 2022 07:30:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D95F6E1FD; Tue, 18 Jan 2022 07:30:22 +0000 (UTC) From: Florian Weimer To: Aurelien Jarno Cc: libc-stable@sourceware.org Subject: Re: Help backporting CVE-2022-23218 / bug 28768 to 2.33 and older References: Date: Tue, 18 Jan 2022 08:30:20 +0100 In-Reply-To: (Aurelien Jarno's message of "Tue, 18 Jan 2022 07:57:00 +0100") Message-ID: <87wnixlcvn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 07:30:27 -0000 * Aurelien Jarno: > Hi all, > > I am trying to backport commit f545ad4928fa to glibc 2.33 and older > releases. I noticed it contains a test which does not compile in such > branches due to the use of compat_symbol_reference. > > I see to options to fix that in the backport: > - backport commit 36f6e408845c8 (": Support > compat_symbol_reference for _ISOMAC") > - move the test to tests-internal for older releases, just like it was > the case for some tests before the above commit. > > Which one of the two options is the best? Any other ideas? Backporting commit 36f6e408845c8 seems reasonable to me. Thanks. Florian