From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 9AFF73858C52; Fri, 23 Sep 2022 10:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9AFF73858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x831.google.com with SMTP id a20so8097820qtw.10; Fri, 23 Sep 2022 03:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=bfaqlKNeM7HFf6RhYNkYprX0e/PLMTPAM+Mn5OkmC9w=; b=LI/tpDxXc9h751gbFswImuskc8WBHwF4iS6OeH6G1i7VbgyzDOxjvsX0lTMl9Vre7t 6+U7rtz1/0/j8xDKOEIU9+t1r/GcZ8+iotOLsheUutsxrsFuAc/HAw8wYMycVSFCJKbH vpU5YHkGjQRBrqideo7+E1ZIN4/zVULJ9MwJpZuN5aSBoSyLRPBCmTwhA3UD6ghSp61R TDwJlvJa2k5uCsqP6PBaQcFmhuLUnojjRGCqPSOL1xv1jBV5Vfrb/Tz1vQNatZcJicWj Q1GYRWp8fVhZ2OnyqLslzld1ER0vU+uMQciFFhwO1YSuIIa5qU9bheFnJoT3LAW2YelR O+Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=bfaqlKNeM7HFf6RhYNkYprX0e/PLMTPAM+Mn5OkmC9w=; b=5iWsxg4OrJmfeAkrhyY9MTMYR41LXY0qAfYSmJBVVjJWwpLr2C0jm4j3exFbyVbvQW YX8fnIf66gCrEVOsTPxEAvPsDoDxAQwRBiqjOgMkV1BQs45NOLcimzoKqAGpRX+FjwMF o1nCoz/Iyy7c1lq4bV/biMw9Fhb05hIaWYxRirS2LPHMRDGULTQMW5efoxuSQHpZRGkz nDrk/a+J3CYcqLmd0T+F/hWhNFLIO/J07hOvTWPOQv0+ToxPedPJsbxrtVQKYWqTEcEi hfdDeaptAL4MBPKk3NH59VMTJhwQFIvNflRKarUjOOpkyeQTjAFnCL5XGpScPftB9Wxd lcEA== X-Gm-Message-State: ACrzQf1AMXbxOrAaXK2ZiimeADKDfbqQqlQ7EsjiO+VPdTyHmBXU1W7L O6PG73meiQK0HEy5hAkrmGQFIwoXvdQ87yCI2PXls8i6 X-Google-Smtp-Source: AMsMyM6NPG7uSTOYZWngBx6W1Yaf5hE3sI49Qs4pjZpq08BEa7pyZQbtnaRANiK0rJGDazA7wl9EWGH7zc52dAlFd2s= X-Received: by 2002:ac8:5e4d:0:b0:35d:157e:50c with SMTP id i13-20020ac85e4d000000b0035d157e050cmr5718545qtx.90.1663930205258; Fri, 23 Sep 2022 03:50:05 -0700 (PDT) MIME-Version: 1.0 References: <20210623222846.2162301-1-hjl.tools@gmail.com> <20210623222846.2162301-2-hjl.tools@gmail.com> In-Reply-To: From: =?UTF-8?B?6Kyd5piH6YGUKFNoZW4tVGEgSHNpZWgp?= Date: Fri, 23 Sep 2022 18:49:53 +0800 Message-ID: Subject: Re: [PATCH v8 1/4] math: redirect roundeven function To: Noah Goldstein Cc: Sunil Pandey , "H.J. Lu" , Libc-stable Mailing List , Florian Weimer , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Fine by me, too Noah Goldstein =E6=96=BC 2022=E5=B9=B49=E6=9C=881= 4=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=889:25=E5=AF=AB=E9=81=93=EF= =BC=9A > > On Sun, Sep 11, 2022 at 12:57 PM Sunil Pandey via Libc-stable > wrote: > > > > On Wed, Jun 23, 2021 at 3:32 PM H.J. Lu via Libc-alpha > > wrote: > > > > > > From: Shen-Ta Hsieh > > > > > > This patch redirect roundeven function for futhermore changes. > > > > > > Signed-off-by: Shen-Ta Hsieh > > > Reviewed-by: H.J. Lu > > > --- > > > include/math.h | 2 +- > > > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++- > > > sysdeps/ieee754/float128/s_roundevenf128.c | 1 + > > > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++ > > > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 + > > > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 + > > > 6 files changed, 10 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/math.h b/include/math.h > > > index e1c2a4eb64..b4772d3d3b 100644 > > > --- a/include/math.h > > > +++ b/include/math.h > > > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling) > > > libm_hidden_proto (__issignalingf) > > > libm_hidden_proto (__exp) > > > libm_hidden_proto (__expf) > > > -libm_hidden_proto (__roundeven) > > > > > > # if !defined __NO_LONG_DOUBLE_MATH \ > > > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI =3D=3D 0 > > > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x) > > > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS) > > > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS) > > > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS) > > > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS) > > > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS) > > > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS) > > > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS) > > > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/d= bl-64/s_roundeven.c > > > index 943b2c634c..5deff3bb8a 100644 > > > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c > > > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c > > > @@ -16,6 +16,7 @@ > > > License along with the GNU C Library; if not, see > > > . */ > > > > > > +#define NO_MATH_REDIRECT > > > #include > > > #include > > > #include > > > @@ -66,5 +67,6 @@ __roundeven (double x) > > > INSERT_WORDS64 (x, ix); > > > return x; > > > } > > > -hidden_def (__roundeven) > > > +#ifndef __roundeven > > > libm_alias_double (__roundeven, roundeven) > > > +#endif > > > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/iee= e754/float128/s_roundevenf128.c > > > index 5a9b3f395f..e0faf727f6 100644 > > > --- a/sysdeps/ieee754/float128/s_roundevenf128.c > > > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c > > > @@ -1,2 +1,3 @@ > > > +#define NO_MATH_REDIRECT > > > #include > > > #include "../ldbl-128/s_roundevenl.c" > > > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/= flt-32/s_roundevenf.c > > > index ae54365bbe..2cc0d7b001 100644 > > > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c > > > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c > > > @@ -17,6 +17,7 @@ > > > License along with the GNU C Library; if not, see > > > . */ > > > > > > +#define NO_MATH_REDIRECT > > > #include > > > #include > > > #include > > > @@ -67,4 +68,6 @@ __roundevenf (float x) > > > SET_FLOAT_WORD (x, ix); > > > return x; > > > } > > > +#ifndef __roundevenf > > > libm_alias_float (__roundeven, roundeven) > > > +#endif > > > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee75= 4/ldbl-128/s_roundevenl.c > > > index 02765be0e0..7c9c11fad2 100644 > > > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > > @@ -17,6 +17,7 @@ > > > License along with the GNU C Library; if not, see > > > . */ > > > > > > +#define NO_MATH_REDIRECT > > > #include > > > #include > > > #include > > > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee754= /ldbl-96/s_roundevenl.c > > > index 8340116ed8..f826829c31 100644 > > > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > > @@ -17,6 +17,7 @@ > > > License along with the GNU C Library; if not, see > > > . */ > > > > > > +#define NO_MATH_REDIRECT > > > #include > > > #include > > > #include > > > -- > > > 2.31.1 > > > > > > > I would like to backport this patch to release branch 2.33. > > > > Any comments/suggestions or objections on this. > > > > commit 447954a206837b5f153869cfeeeab44631c3fac9 > > Author: Shen-Ta Hsieh > > Date: Mon May 24 09:43:10 2021 +0800 > > > > math: redirect roundeven function > > > > This patch redirect roundeven function for futhermore changes. > > > > Signed-off-by: Shen-Ta Hsieh > > Reviewed-by: H.J. Lu > > Fine by me.