From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 0BA81385829E; Wed, 14 Sep 2022 01:25:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BA81385829E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id bj12so31258345ejb.13; Tue, 13 Sep 2022 18:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=B0Xn8nApIyxczk74wZK9MMpTkyc6oAZOzVkMkydbnmo=; b=LtDQr24CxDGLE23UWmVcnFMkJhgf3ClnfnqLFrlcVQ340L8t0/hkm8B4qv5wqYFQ08 5js+3NWxctuZwPH/EuEeBXWGrdI+GlQ/I6RDTUjdiBJynrHBkPkryIAtZts/oY25AaRf wIXkx1J67FfZi/62bPucvIcXO3oMUHop5nCnGOgSzCC3/Qquh7bvy4uj3mvvf0IY/GXD C/uWZ9+xsWgzQgYiL4MYuktIcihqLu8LyIyR3gdKttZG8VuiZTNfw3jjYyJ9qucTo9/2 EAxj7f/CBVr3UDfQpG8Wr3tlzrcPlvEX6knIMI9yqwloW74tVHMr3TQWR//OV8oiFeyJ xOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=B0Xn8nApIyxczk74wZK9MMpTkyc6oAZOzVkMkydbnmo=; b=NoQIb4djfJvd0jtU0QvhHGFbKH2N64jus1+JhFaX/7QTwjF7S1TUFEkBwxB59IE+er WDIw5CCzmUFK4Nevq5WgRdo86cgji/AQGYRqzfKG936aBllIO8eZnI97nEFmVsX3KyLC z5gqN6ZSfp+Ws9UmTnAdTLZbIevbauicC+ZSDor76dp6M+j3p8xc7r9OtCStu2HUgfbZ udPSLq5/eBEJ1z9wqtLd+4zUK1ZHOtRB0KX9pqskWJwRf8nhLoHZmMYGSmgTc1P6gA6S dbDGJzzw+5cH+TqVksN0HzhODFbVdj47xOfS4pIVcJ1tujb7bfmipN4inGOoB05z1nDn mxQg== X-Gm-Message-State: ACgBeo39tZXPkXNjX7jEes9dT6ts3a6oGYrIfY4NNhu7xqI+SxobUEBY Zt/fQNLFO54rWCBODiy5iddBmosy3ARKSI+avTc= X-Google-Smtp-Source: AA6agR5YnEecrA8/fnbLxuO+u8A2EqyXn3zHOZRvMDelHOHNZwbBKfyUSOdqMSB37MHyHb6qfu62lt54vYMJ96+yH18= X-Received: by 2002:a17:906:730b:b0:77f:9688:272f with SMTP id di11-20020a170906730b00b0077f9688272fmr5916202ejc.282.1663118728516; Tue, 13 Sep 2022 18:25:28 -0700 (PDT) MIME-Version: 1.0 References: <20210623222846.2162301-1-hjl.tools@gmail.com> <20210623222846.2162301-2-hjl.tools@gmail.com> In-Reply-To: From: Noah Goldstein Date: Tue, 13 Sep 2022 18:25:17 -0700 Message-ID: Subject: Re: [PATCH v8 1/4] math: redirect roundeven function To: Sunil Pandey Cc: "H.J. Lu" , Libc-stable Mailing List , Florian Weimer , Shen-Ta Hsieh , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Sep 11, 2022 at 12:57 PM Sunil Pandey via Libc-stable wrote: > > On Wed, Jun 23, 2021 at 3:32 PM H.J. Lu via Libc-alpha > wrote: > > > > From: Shen-Ta Hsieh > > > > This patch redirect roundeven function for futhermore changes. > > > > Signed-off-by: Shen-Ta Hsieh > > Reviewed-by: H.J. Lu > > --- > > include/math.h | 2 +- > > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++- > > sysdeps/ieee754/float128/s_roundevenf128.c | 1 + > > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++ > > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 + > > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 + > > 6 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/include/math.h b/include/math.h > > index e1c2a4eb64..b4772d3d3b 100644 > > --- a/include/math.h > > +++ b/include/math.h > > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling) > > libm_hidden_proto (__issignalingf) > > libm_hidden_proto (__exp) > > libm_hidden_proto (__expf) > > -libm_hidden_proto (__roundeven) > > > > # if !defined __NO_LONG_DOUBLE_MATH \ > > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 0 > > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x) > > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS) > > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS) > > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/dbl-64/s_roundeven.c > > index 943b2c634c..5deff3bb8a 100644 > > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c > > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c > > @@ -16,6 +16,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > @@ -66,5 +67,6 @@ __roundeven (double x) > > INSERT_WORDS64 (x, ix); > > return x; > > } > > -hidden_def (__roundeven) > > +#ifndef __roundeven > > libm_alias_double (__roundeven, roundeven) > > +#endif > > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/ieee754/float128/s_roundevenf128.c > > index 5a9b3f395f..e0faf727f6 100644 > > --- a/sysdeps/ieee754/float128/s_roundevenf128.c > > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c > > @@ -1,2 +1,3 @@ > > +#define NO_MATH_REDIRECT > > #include > > #include "../ldbl-128/s_roundevenl.c" > > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/flt-32/s_roundevenf.c > > index ae54365bbe..2cc0d7b001 100644 > > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c > > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > @@ -67,4 +68,6 @@ __roundevenf (float x) > > SET_FLOAT_WORD (x, ix); > > return x; > > } > > +#ifndef __roundevenf > > libm_alias_float (__roundeven, roundeven) > > +#endif > > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > index 02765be0e0..7c9c11fad2 100644 > > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > index 8340116ed8..f826829c31 100644 > > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > -- > > 2.31.1 > > > > I would like to backport this patch to release branch 2.33. > > Any comments/suggestions or objections on this. > > commit 447954a206837b5f153869cfeeeab44631c3fac9 > Author: Shen-Ta Hsieh > Date: Mon May 24 09:43:10 2021 +0800 > > math: redirect roundeven function > > This patch redirect roundeven function for futhermore changes. > > Signed-off-by: Shen-Ta Hsieh > Reviewed-by: H.J. Lu Fine by me.