From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <goldstein.w.n@gmail.com>
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com
 [IPv6:2607:f8b0:4864:20::102a])
 by sourceware.org (Postfix) with ESMTPS id 047F33857805;
 Thu, 17 Feb 2022 19:17:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 047F33857805
Received: by mail-pj1-x102a.google.com with SMTP id
 t14-20020a17090a3e4e00b001b8f6032d96so6378413pjm.2; 
 Thu, 17 Feb 2022 11:17:39 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=oSIDackzXCWO3Z8cfGICcmh3HFYMGJaQ2gUy3rIr31Q=;
 b=Gxa1OWFecdyK9YR6GWsNuglyVuYfl85hQxd6A3XTVLp29IscEgWbWydqczdxjqiRrD
 9eLPyQK/+hAEx4NyZkL6cklfSk377rgjiP4gwKo/9YwiVzHiNHuExHEfqcqBdsx4ZNAo
 C89x8DsCyzS/j2jwbbU6Yk5YywV0XpRgqJ7pkmjiSDWmVNHtCuaZUVrrv4JL/qvhyovx
 eRQBy3vEZtpXI15NWf3IGRqe9109/xTT8EPeMAZgRZvLUotW3Ud8EmZA5cei+NviHHGs
 Oahcs71lijrhBwbzCXl+sWNj7vGzH5QYg3akoJMaj6KMuoslxCR/5/nG67L3YjdIYfRM
 oLaw==
X-Gm-Message-State: AOAM5323166fRRa/4LummP+vYMej3IlCaLgSNhsGuEkVGSwlRZYLVEPV
 Ft1VNhYnZ823KxFQWwL/BAyssiYzIlrO2ueZaWE=
X-Google-Smtp-Source: ABdhPJyxZh8+SPLjswMEcBH2xGdSKxJ7x8S5u+Rz4308TXIFp+OBAEHAbJqF7OWjTcHkgzbWghJA5gEEdzStHPdjuFY=
X-Received: by 2002:a17:90a:e38e:b0:1b9:c98b:62e4 with SMTP id
 b14-20020a17090ae38e00b001b9c98b62e4mr4509760pjz.208.1645125459185; Thu, 17
 Feb 2022 11:17:39 -0800 (PST)
MIME-Version: 1.0
References: <20220217162831.417972-1-hjl.tools@gmail.com>
 <CAMAf5_ei=o4i2GKe07xSQg+32uA5Bq+PB3TNNwchTkr0zHevMg@mail.gmail.com>
 <CAMe9rOpmKwoZvnaqgijSrFb-7fmuVURqBOzfbZ=kqTVo5GjU3Q@mail.gmail.com>
In-Reply-To: <CAMe9rOpmKwoZvnaqgijSrFb-7fmuVURqBOzfbZ=kqTVo5GjU3Q@mail.gmail.com>
From: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Thu, 17 Feb 2022 13:17:28 -0600
Message-ID: <CAFUsyfLtREaQMBwiazxq21LZu5DFah2ECuBOqtRGLZOLM-sJBg@mail.gmail.com>
Subject: Re: [PATCH] string: Add a testcase for wcsncmp with SIZE_MAX [BZ
 #28755]
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Sunil Pandey <skpgkp2@gmail.com>, 
 Libc-stable Mailing List <libc-stable@sourceware.org>,
 GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-stable@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-stable mailing list <libc-stable.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-stable/>
List-Help: <mailto:libc-stable-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-stable>,
 <mailto:libc-stable-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Feb 2022 19:17:41 -0000

On Thu, Feb 17, 2022 at 1:06 PM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Thu, Feb 17, 2022 at 10:58 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> >
> > LGTM
> >
> > Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
>
> I am backporting this to release branches.
We will also need to backport the change of target for the RTM + AVX2 versions.


>
> > On Thu, Feb 17, 2022 at 8:28 AM H.J. Lu via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> > >
> > > Verify that wcsncmp (L"abc", L"abd", SIZE_MAX) == 0.  The new test fails
> > > without
> > >
> > > commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87
> > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > Date:   Sun Jan 9 16:02:21 2022 -0600
> > >
> > >     x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]
> > >
> > > and
> > >
> > > commit 7e08db3359c86c94918feb33a1182cd0ff3bb10b
> > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > Date:   Sun Jan 9 16:02:28 2022 -0600
> > >
> > >     x86: Fix __wcsncmp_evex in strcmp-evex.S [BZ# 28755]
> > >
> > > This is for BZ #28755.
> > > ---
> > >  string/test-strncmp.c | 13 +++++++++++++
> > >  1 file changed, 13 insertions(+)
> > >
> > > diff --git a/string/test-strncmp.c b/string/test-strncmp.c
> > > index df7cea4068..1a87f0e73e 100644
> > > --- a/string/test-strncmp.c
> > > +++ b/string/test-strncmp.c
> > > @@ -445,6 +445,18 @@ check4 (void)
> > >    check_result (impl, s1, s2, size, exp_result);
> > >  }
> > >
> > > +static void
> > > +check5 (void)
> > > +{
> > > +  const CHAR *s1 = L ("abc");
> > > +  CHAR *s2 = STRDUP (s1);
> > > +
> > > +  FOR_EACH_IMPL (impl, 0)
> > > +    check_result (impl, s1, s2, SIZE_MAX, 0);
> > > +
> > > +  free (s2);
> > > +}
> > > +
> > >  static void
> > >  check_overflow (void)
> > >  {
> > > @@ -569,6 +581,7 @@ test_main (void)
> > >    check2 ();
> > >    check3 ();
> > >    check4 ();
> > > +  check5 ();
> > >
> > >    printf ("%23s", "");
> > >    FOR_EACH_IMPL (impl, 0)
> > > --
> > > 2.35.1
> > >
>
>
>
> --
> H.J.