From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 57AE2385840E; Fri, 10 May 2024 03:56:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57AE2385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57AE2385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715313391; cv=none; b=aFd04jAvh0utzs+oNS5bp2Bqj1GWH55BC+CFyV7b2Nb+w7BMLBqHinHUAM3ydjT6GNhBl7tv97EEiU09aY26T2V5PVimGxZBWyURw/lv/IKZXMAf/mu+xPDGFNOgkbWvGjvDi+ubzHNdGA2h/OSPcY/Efm72EfUBTLY4DNyw26U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715313391; c=relaxed/simple; bh=dwfTlKgtbFlUiO/AQJp6RgAJfhsaNpCPlG34+w+Dl70=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SP04H+EikHIpi2hNwk7+LB3cpApGPdMo7EC1waXvpTSnp3aAYLFky2uKAMZTWFs3fELOoiovPMrgwBYsoD8Lpi0+lZK/u9WVuCLdfahX2dwC6+MU95S7ZVp5Pyf95+ejfK14PBeN9375cJvTjus6i3tFCIS2Il7b67a6I1kDdns= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-41b79451128so12573995e9.0; Thu, 09 May 2024 20:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715313388; x=1715918188; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uqoJimVj/JxQjvDu1ie8+1KFXnWr9f+6TGs4HCtZbX0=; b=BF/hQ9kc+QMQuf/4SmWCT6apCGkzshrujzwSmgGlfss+ZfuO5zAQwAE6r5o4QWDPSd lAziNNHrqCipkg426LCk7DDfn3a4ZtvgdNDufpln9w9Yp0zZiJUFLm/HsdIpsZ0VzAoP jfUSUgvGf04XhPcNj4u/bejZM5zp45gpq88KBDI8r8dmP0qNL03jlcfHrMwSjDYsCe89 Fz4iV+wn/57Jvo28NqO+FkENsTU7hB7mSgEu8nDcXA83FpkeSaSy49fOEYeIfC8MW9rc CnutJBTxIHIOdThi3dQIFshzZs2viOMcJGAl2krwh0qM+IrT4N/t75YY3a+2sCGh9xOo 6M3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715313388; x=1715918188; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uqoJimVj/JxQjvDu1ie8+1KFXnWr9f+6TGs4HCtZbX0=; b=ItqUkmZCScRF7+Ewwf93AX0frTVUv3r+Tw9BXuHA4U1AiP/ur1scH+BO92RruyGeD5 /ZfA2UjobW0AionSu1Ol0eFkeYDv1nkxYWvqaqDjpmRZEKoSx1kP9Vra6x6UNm/3Y5xM IMgVI43MPvnXt5nPKwPpg+i9UX4dEHtCKn8gpQ9jEXBC7pdj0Nt4KqxpzHd0uhTU2PMT 1cNSe7bVzj+lRJXepxDAE5BhQyZnMvY/Nahp1CEOmrJe9hdWuks8pROXjRM5tx/hGkOq n1/qPunWLymC95YqFE+Sl8wF/VHlT0zH98+3cdaADtmlQSCU84Q5Bwsu2n1jg1Zyjl0q mQ3w== X-Forwarded-Encrypted: i=1; AJvYcCUsmGD7mXN7m9mdkDgO/gHRZmARSty+9CuAxe5fHIPSYWk71P85QCcatcw77BHKIFURF83oP++ZnUljZ7AhVEF/28w9GWn7bEf+sw== X-Gm-Message-State: AOJu0YyC4MM+mxQNn9+scW+YIi4mzESQn8I+4qGxzy8FIVORx+/OSksV r5P/PyHJ6XGbRGztdqA/eFP3h5WjU9z5lqg3OUbCc6JSWP2dG9r5vKKs+CZBlsp/NOm9X092pu+ oVl/4YNc1adA6phBb5tTqmrXZ4VWpb1rz X-Google-Smtp-Source: AGHT+IEG+sQeR2Z8oSNXZaMII9dLCtZVdvv6ap6FAuQjW8YmWpZsfI0XI4DEDOUBtV8PCpD24iQbjxOIe6B/u3z1FhQ= X-Received: by 2002:adf:e0ce:0:b0:34d:7d03:4602 with SMTP id ffacd0b85a97d-3504a6334b8mr790510f8f.1.1715313387942; Thu, 09 May 2024 20:56:27 -0700 (PDT) MIME-Version: 1.0 References: <20240510030701.834418-1-hjl.tools@gmail.com> In-Reply-To: <20240510030701.834418-1-hjl.tools@gmail.com> From: Sunil Pandey Date: Thu, 9 May 2024 20:55:51 -0700 Message-ID: Subject: Re: [PATCH] Force DT_RPATH for --enable-hardcoded-path-in-tests To: "H.J. Lu" , Libc-stable Mailing List Cc: libc-alpha@sourceware.org Content-Type: multipart/alternative; boundary="0000000000002ab97e0618118565" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002ab97e0618118565 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 9, 2024 at 8:07=E2=80=AFPM H.J. Lu wrote: > On Fedora 40/x86-64, linker enables --enable-new-dtags by default which > generates DT_RUNPATH instead of DT_RPATH. Unlike DT_RPATH, DT_RUNPATH > only applies to DT_NEEDED entries in the executable and doesn't applies > to DT_NEEDED entries in shared libraries which are loaded via DT_NEEDED > entries in the executable. Some glibc tests have libstdc++.so.6 in > DT_NEEDED, which has libm.so.6 in DT_NEEDED. When DT_RUNPATH is generate= d, > /lib64/libm.so.6 is loaded for such tests. If the newly built glibc is > older than glibc 2.36, these tests fail with > > assert/tst-assert-c++: > /export/build/gnu/tools-build/glibc-gitlab-release/build-x86_64-linux/lib= c.so.6: > version `GLIBC_2.36' not found (required by /lib64/libm.so.6) > assert/tst-assert-c++: > /export/build/gnu/tools-build/glibc-gitlab-release/build-x86_64-linux/lib= c.so.6: > version `GLIBC_ABI_DT_RELR' not found (required by /lib64/libm.so.6) > > Pass -Wl,--disable-new-dtags to linker when building glibc tests with > --enable-hardcoded-path-in-tests. This fixes BZ #31719. > > Signed-off-by: H.J. Lu > --- > Makeconfig | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Makeconfig b/Makeconfig > index 61ff1d0d9b..59e21d4c82 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -607,10 +607,13 @@ link-libc-rpath-link =3D -Wl,-rpath-link=3D$(rpath-= link) > # before the expansion of LDLIBS-* variables). > > # Tests use -Wl,-rpath instead of -Wl,-rpath-link for > -# build-hardcoded-path-in-tests. > +# build-hardcoded-path-in-tests. Add -Wl,--disable-new-dtags to force > +# DT_RPATH instead of DT_RUNPATH which only applies to DT_NEEDED entries > +# in the executable and doesn't applies to DT_NEEDED entries in shared > +# libraries which are loaded via DT_NEEDED entries in the executable. > ifeq (yes,$(build-hardcoded-path-in-tests)) > -link-libc-tests-rpath-link =3D $(link-libc-rpath) > -link-test-modules-rpath-link =3D $(link-libc-rpath) > +link-libc-tests-rpath-link =3D $(link-libc-rpath) -Wl,--disable-new-dtags > +link-test-modules-rpath-link =3D $(link-libc-rpath) -Wl,--disable-new-dt= ags > else > link-libc-tests-rpath-link =3D $(link-libc-rpath-link) > link-test-modules-rpath-link =3D > -- > 2.45.0 > > I would like to backport this patch to release branches up to 2.28. Any comments or objections? --Sunil --0000000000002ab97e0618118565--