From: Sunil Pandey <skpgkp2@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: Noah Goldstein <goldstein.w.n@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1 2/2] x86: Small improvements for wcslen
Date: Thu, 12 May 2022 12:55:12 -0700 [thread overview]
Message-ID: <CAMAf5_d3xeG1th0y-qpFm32nKXL09TtYDd+x71jH2Fqq4LwJ9w@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOo+mCgBdnhz4b9O52Cuy5GGmc08KB9XPuH0RDJpCrT5sg@mail.gmail.com>
On Mon, Mar 28, 2022 at 11:53 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Fri, Mar 25, 2022 at 3:13 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > Just a few QOL changes.
> > 1. Prefer `add` > `lea` as it has high execution units it can run
> > on.
> > 2. Don't break macro-fusion between `test` and `jcc`
> > 3. Reduce code size by removing gratuitous padding bytes (-90
> > bytes).
> >
> > geometric_mean(N=20) of all benchmarks New / Original: 0.959
> >
> > All string/memory tests pass.
> > ---
> > sysdeps/x86_64/wcslen.S | 86 ++++++++++++++++++++---------------------
> > 1 file changed, 41 insertions(+), 45 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/wcslen.S b/sysdeps/x86_64/wcslen.S
> > index c9165dbf03..d641141d75 100644
> > --- a/sysdeps/x86_64/wcslen.S
> > +++ b/sysdeps/x86_64/wcslen.S
> > @@ -40,82 +40,82 @@ ENTRY (__wcslen)
> > pxor %xmm0, %xmm0
> >
> > lea 32(%rdi), %rax
> > - lea 16(%rdi), %rcx
> > + addq $16, %rdi
> > and $-16, %rax
> >
> > pcmpeqd (%rax), %xmm0
> > pmovmskb %xmm0, %edx
> > pxor %xmm1, %xmm1
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm1
> > pmovmskb %xmm1, %edx
> > pxor %xmm2, %xmm2
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm2
> > pmovmskb %xmm2, %edx
> > pxor %xmm3, %xmm3
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm0
> > pmovmskb %xmm0, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm1
> > pmovmskb %xmm1, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm2
> > pmovmskb %xmm2, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm0
> > pmovmskb %xmm0, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm1
> > pmovmskb %xmm1, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm2
> > pmovmskb %xmm2, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > pcmpeqd (%rax), %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $16, %rax
> > test %edx, %edx
> > - lea 16(%rax), %rax
> > jnz L(exit)
> >
> > and $-0x40, %rax
> > @@ -132,104 +132,100 @@ L(aligned_64_loop):
> > pminub %xmm0, %xmm2
> > pcmpeqd %xmm3, %xmm2
> > pmovmskb %xmm2, %edx
> > + addq $64, %rax
> > test %edx, %edx
> > - lea 64(%rax), %rax
> > jz L(aligned_64_loop)
> >
> > pcmpeqd -64(%rax), %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $48, %rdi
> > test %edx, %edx
> > - lea 48(%rcx), %rcx
> > jnz L(exit)
> >
> > pcmpeqd %xmm1, %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $-16, %rdi
> > test %edx, %edx
> > - lea -16(%rcx), %rcx
> > jnz L(exit)
> >
> > pcmpeqd -32(%rax), %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $-16, %rdi
> > test %edx, %edx
> > - lea -16(%rcx), %rcx
> > jnz L(exit)
> >
> > pcmpeqd %xmm6, %xmm3
> > pmovmskb %xmm3, %edx
> > + addq $-16, %rdi
> > test %edx, %edx
> > - lea -16(%rcx), %rcx
> > - jnz L(exit)
> > -
> > - jmp L(aligned_64_loop)
> > + jz L(aligned_64_loop)
> >
> > .p2align 4
> > L(exit):
> > - sub %rcx, %rax
> > + sub %rdi, %rax
> > shr $2, %rax
> > test %dl, %dl
> > jz L(exit_high)
> >
> > - mov %dl, %cl
> > - and $15, %cl
> > + andl $15, %edx
> > jz L(exit_1)
> > ret
> >
> > - .p2align 4
> > + /* No align here. Naturally aligned % 16 == 1. */
> > L(exit_high):
> > - mov %dh, %ch
> > - and $15, %ch
> > + andl $(15 << 8), %edx
> > jz L(exit_3)
> > add $2, %rax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_1):
> > add $1, %rax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_3):
> > add $3, %rax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail0):
> > - xor %rax, %rax
> > + xorl %eax, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail1):
> > - mov $1, %rax
> > + movl $1, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail2):
> > - mov $2, %rax
> > + movl $2, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail3):
> > - mov $3, %rax
> > + movl $3, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail4):
> > - mov $4, %rax
> > + movl $4, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail5):
> > - mov $5, %rax
> > + movl $5, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail6):
> > - mov $6, %rax
> > + movl $6, %eax
> > ret
> >
> > - .p2align 4
> > + .p2align 3
> > L(exit_tail7):
> > - mov $7, %rax
> > + movl $7, %eax
> > ret
> >
> > END (__wcslen)
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>
> --
> H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
parent reply other threads:[~2022-05-12 19:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAMe9rOo+mCgBdnhz4b9O52Cuy5GGmc08KB9XPuH0RDJpCrT5sg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMAf5_d3xeG1th0y-qpFm32nKXL09TtYDd+x71jH2Fqq4LwJ9w@mail.gmail.com \
--to=skpgkp2@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).