From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by sourceware.org (Postfix) with ESMTPS id 3A6B43858D28; Thu, 28 Apr 2022 00:07:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A6B43858D28 Received: by mail-vk1-xa34.google.com with SMTP id e144so1618901vke.9; Wed, 27 Apr 2022 17:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BeK4NFrbRLuwVanubqi25AQ4SNU151LDjaGyar+uM+Q=; b=D4oWNhhy8mXHGP9cLqH/SeODY8LHyRpY61lFcHiQTAnKWnSJi9lUW8bXeU1JlgOd8M 60P0ZKnX+xganAAHNd21gx34GSQl+QyiL80dFCwTWOdJ5C6E/qcClw5EOFt8RAaWrRrR dxktwL0wHhp9SQw4+A+9mbcnQ4Vs4B+EQM4FyQzLzS7ALvzvXwymKl7xFJ1iBLDTsg6s JrQxxGkyt06Un1hYUIIasa69GQu6lQs7EeDOrMeITyZYkIFo28HR3f8UCuatp+TYbf7i qfKq3uTMJqPbCzI+/bbxAhzm4vSTwS9mrl1u11Sv/J662ZKL8OTdn27RqD+GIVTyO2LF kRaw== X-Gm-Message-State: AOAM533vRP+5ioZNPNZq0Ll7IMetpAKXw2w4La2lONcwO+l8+2T9IWug fzmR/TCykrtiuCV4GKTvui4vCI1e9EJgOZqNxNk= X-Google-Smtp-Source: ABdhPJyF0qRk86TIvkh/x3wYTJMikJX5ziYh+mHSmqeUnIQ8LDYIgpPAN2Fflgxn3FTcQVh3O1dRUqiBgmhH78kq7jM= X-Received: by 2002:a1f:2c0b:0:b0:345:e29e:cb24 with SMTP id s11-20020a1f2c0b000000b00345e29ecb24mr9917241vks.7.1651104475505; Wed, 27 Apr 2022 17:07:55 -0700 (PDT) MIME-Version: 1.0 References: <20210524013020.1869687-2-goldstein.w.n@gmail.com> <20210524031502.1975741-1-goldstein.w.n@gmail.com> <20210524031502.1975741-2-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Wed, 27 Apr 2022 17:07:19 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] x86: Improve memmove-vec-unaligned-erms.S To: "H.J. Lu" , libc-stable@sourceware.org Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 00:07:58 -0000 On Sun, May 23, 2021 at 8:40 PM H.J. Lu via Libc-alpha wrote: > > On Sun, May 23, 2021 at 8:15 PM Noah Goldstein wrote: > > > > This patch changes the condition for copy 4x VEC so that if length is > > exactly equal to 4 * VEC_SIZE it will use the 4x VEC case instead of > > 8x VEC case. > > > > Results For Skylake memcpy-avx2-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 9.137 , 6.873 , New , 75.22 > > 128 , 7 , 0 , 12.933 , 7.732 , New , 59.79 > > 128 , 0 , 7 , 11.852 , 6.76 , New , 57.04 > > 128 , 7 , 7 , 12.587 , 6.808 , New , 54.09 > > > > Results For Icelake memcpy-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 9.963 , 5.416 , New , 54.36 > > 128 , 7 , 0 , 16.467 , 8.061 , New , 48.95 > > 128 , 0 , 7 , 14.388 , 7.644 , New , 53.13 > > 128 , 7 , 7 , 14.546 , 7.642 , New , 52.54 > > > > Results For Tigerlake memcpy-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 0 , 8.979 , 4.95 , New , 55.13 > > 128 , 7 , 0 , 14.245 , 7.122 , New , 50.0 > > 128 , 0 , 7 , 12.668 , 6.675 , New , 52.69 > > 128 , 7 , 7 , 13.042 , 6.802 , New , 52.15 > > > > Results For Skylake memmove-avx2-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 6.181 , 5.691 , New , 92.07 > > 128 , 32 , 0 , 6.165 , 5.752 , New , 93.3 > > 128 , 0 , 7 , 13.923 , 9.37 , New , 67.3 > > 128 , 7 , 0 , 12.049 , 10.182 , New , 84.5 > > > > Results For Icelake memmove-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 5.479 , 4.889 , New , 89.23 > > 128 , 32 , 0 , 5.127 , 4.911 , New , 95.79 > > 128 , 0 , 7 , 18.885 , 13.547 , New , 71.73 > > 128 , 7 , 0 , 15.565 , 14.436 , New , 92.75 > > > > Results For Tigerlake memmove-evex-erms > > size, al1 , al2 , Cur T , New T , Win , New / Cur > > 128 , 0 , 32 , 5.275 , 4.815 , New , 91.28 > > 128 , 32 , 0 , 5.376 , 4.565 , New , 84.91 > > 128 , 0 , 7 , 19.426 , 14.273 , New , 73.47 > > 128 , 7 , 0 , 15.924 , 14.951 , New , 93.89 > > > > Signed-off-by: Noah Goldstein > > --- > > sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > index 5e4a071f16..a783da5de2 100644 > > --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > > @@ -420,8 +420,8 @@ L(more_2x_vec): > > cmpq $(VEC_SIZE * 8), %rdx > > ja L(more_8x_vec) > > cmpq $(VEC_SIZE * 4), %rdx > > - jb L(last_4x_vec) > > - /* Copy from 4 * VEC to 8 * VEC, inclusively. */ > > + jbe L(last_4x_vec) > > + /* Copy from 4 * VEC + 1 to 8 * VEC, inclusively. */ > > VMOVU (%rsi), %VEC(0) > > VMOVU VEC_SIZE(%rsi), %VEC(1) > > VMOVU (VEC_SIZE * 2)(%rsi), %VEC(2) > > @@ -440,7 +440,7 @@ L(more_2x_vec): > > VMOVU %VEC(7), -(VEC_SIZE * 4)(%rdi,%rdx) > > VZEROUPPER_RETURN > > L(last_4x_vec): > > - /* Copy from 2 * VEC to 4 * VEC. */ > > + /* Copy from 2 * VEC + 1 to 4 * VEC, inclusively. */ > > VMOVU (%rsi), %VEC(0) > > VMOVU VEC_SIZE(%rsi), %VEC(1) > > VMOVU -VEC_SIZE(%rsi,%rdx), %VEC(2) > > -- > > 2.25.1 > > > > LGTM. > > Reviewed-by: H.J. Lu > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil