public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
From: Sunil Pandey <skpgkp2@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Libc-stable Mailing List <libc-stable@sourceware.org>,
	"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
Date: Tue, 19 Jul 2022 08:55:40 -0700	[thread overview]
Message-ID: <CAMAf5_de37ekzemcuxUTDfTbio8YAeUrrQhbeBu8eVKfVtquyw@mail.gmail.com> (raw)
In-Reply-To: <87pmi18l0j.fsf@oldenburg.str.redhat.com>

On Tue, Jul 19, 2022 at 3:17 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Sunil Pandey via Glibc-cvs:
>
> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010
> >
> > commit f6bc52f080e4a0195c707c01f54e2eae0ff89010
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Fri May 20 19:21:48 2022 -0700
> >
> >     x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
> >
> >     According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
> >     and R_X86_64_JUMP_SLOT.  Since linkers always set their r_addends to 0, we
> >     can ignore their r_addends.
> >
> >     Reviewed-by: Fangrui Song <maskray@google.com>
> >     (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084)
>
> Do we really need to backport this?  It seems a bit risky.
>
> Thanks,
> Florian
>

Hi Florian,

This backport is already pushed to 2.35, 2.34 and 2.33.

Should I revert this commit from 2.34 and 2.33?

Thanks,
Sunil

  reply	other threads:[~2022-07-19 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220719051055.76F3A385801D@sourceware.org>
2022-07-19 10:17 ` Florian Weimer
2022-07-19 15:55   ` Sunil Pandey [this message]
2022-07-19 17:51     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMAf5_de37ekzemcuxUTDfTbio8YAeUrrQhbeBu8eVKfVtquyw@mail.gmail.com \
    --to=skpgkp2@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-stable@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).