From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id 867F73858281 for ; Tue, 19 Jul 2022 15:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 867F73858281 Received: by mail-yb1-xb2f.google.com with SMTP id 7so9652789ybw.0 for ; Tue, 19 Jul 2022 08:56:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IbmNXy9L/PmFyaFG33knA0Qoq8l7G4mgtIh5hHNuKF8=; b=fRVPhdC9BPkCojGnxMsrtHJfMR9Z8tCgJKdJHuUtxBfaax+gLKaLR6LF9U7vhhtjAN l+k0wWtAGsTO4EptPU8d5ir31Hqzc7JWQJ58H3Y4gKi5gRg2zLQx5MLjRDf8oXgnthhG /LzSeaECaTHqN0LhPgurtGq7h8/yUW9uyalvGHBqynEi0M66gs1ek07ZVMdHzgpGul+1 NRul1NDBRkfIoPicsUs6D3nqVrCvlmInSWqrgyJFEnPUMcsXlhqRm3ICiHx4YID6/Yu0 gKATk0iwdAZ2XPpSQTyq/+KfToEauP7yl9kGGMqnZ0CxcG8EOR5rbWqS6IoTWIFUBe7A agcg== X-Gm-Message-State: AJIora/Nb0qoDPnWKe5+Km3R+8jnKF06Q6irgykP0Hh6UrJ1AigGAmKv fhxJ2asxe7Zrlk/ZqFiIaH84RaU1fYsuQ8grSpE= X-Google-Smtp-Source: AGRyM1uQRopG4Zt1F++awoUXf+QTgg15sYjakFKiGEnC5BrMcgFguCOJDWQ+e2pKO3wL9JsaF8N7eDPPNOyL/q1G+fI= X-Received: by 2002:a05:6902:102c:b0:66e:ac5b:7053 with SMTP id x12-20020a056902102c00b0066eac5b7053mr31095064ybt.60.1658246175952; Tue, 19 Jul 2022 08:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20220719051055.76F3A385801D@sourceware.org> <87pmi18l0j.fsf@oldenburg.str.redhat.com> In-Reply-To: <87pmi18l0j.fsf@oldenburg.str.redhat.com> From: Sunil Pandey Date: Tue, 19 Jul 2022 08:55:40 -0700 Message-ID: Subject: Re: [glibc/release/2.34/master] x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT To: Florian Weimer Cc: Libc-stable Mailing List , "H.J. Lu" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 15:56:18 -0000 On Tue, Jul 19, 2022 at 3:17 AM Florian Weimer wrote: > > * Sunil Pandey via Glibc-cvs: > > > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6bc52f080e4a0195c707c01f54e2eae0ff89010 > > > > commit f6bc52f080e4a0195c707c01f54e2eae0ff89010 > > Author: H.J. Lu > > Date: Fri May 20 19:21:48 2022 -0700 > > > > x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT > > > > According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT > > and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we > > can ignore their r_addends. > > > > Reviewed-by: Fangrui Song > > (cherry picked from commit f8587a61892cbafd98ce599131bf4f103466f084) > > Do we really need to backport this? It seems a bit risky. > > Thanks, > Florian > Hi Florian, This backport is already pushed to 2.35, 2.34 and 2.33. Should I revert this commit from 2.34 and 2.33? Thanks, Sunil