From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 5DDCC3858406 for ; Mon, 2 May 2022 14:09:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DDCC3858406 Received: by mail-vs1-xe2c.google.com with SMTP id c62so13658194vsc.10 for ; Mon, 02 May 2022 07:09:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PynSjCK5SzU7kqCpVDOxhe7NjFX6E6VfoLU9F/V+upg=; b=1Ug16TuKi89OiBymQ+FpNjSrkfIL9UDaNqqiVJSg9EKm4m59ROfo6vj2Ozwy4FJr6Y /hvAOYJzY1MfMcxYajLBViUyVTME7+co9f+w74VCUJprO2EAtMMWvDfe/HAmoKfUo7BK auJ8MK9Dv3JIojibGEhE/0gxonjqqCDqjg38i4EYcmIh1a/m4GuQxU1scgUgIXzgO+xj mObxpWb9yZQiFecTeS3XQh2o/2FZ20tHW9O1OFdWXEcRm04+8b6waN/4hVipwqRIutRc e7amMYR+6p5gsqTomdODxf+t73rXoO+Wadgpy4GGEqYhPI/sogfAnoahKHQ7+BHhVXgR dHqQ== X-Gm-Message-State: AOAM533lN8oe5YcitVjHlqKABtTpCHYHuinCd682EiD1hZwRrN/b1lDo Wn2k+c1XXxe21N6Yg1LRQIe/YWlcYdL1McRPmUKnEbrSt+w= X-Google-Smtp-Source: ABdhPJwdgCQ91QIPtvS5x4wfp4ZQ0QyLY1lpb9IxeYjwBUiAa5guD+wOiBumxYKbDwZLmbD4kqoSrdG5FqEQATGY8nU= X-Received: by 2002:a05:6102:3f0f:b0:32a:46dd:a908 with SMTP id k15-20020a0561023f0f00b0032a46dda908mr3140704vsv.48.1651500585510; Mon, 02 May 2022 07:09:45 -0700 (PDT) MIME-Version: 1.0 From: Sunil Pandey Date: Mon, 2 May 2022 07:09:09 -0700 Message-ID: Subject: [backport] Fix misplaced const To: Libc-stable Mailing List , schwab@linux-m68k.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 14:09:47 -0000 I would like to backport this patch to release branches. Any comments or objections? $ git show 31f6488722 commit 31f64887222597bb15b7a814d8dadb7cb667bcb9 Author: Andreas Schwab Date: Mon Jan 25 14:29:45 2021 +0100 Fix misplaced const Constify __x86_cacheinfo_p and __x86_cpu_features_p, not their pointer target types. diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c index 350cba5fda..7b8df45e3b 100644 --- a/sysdeps/x86/cacheinfo.c +++ b/sysdeps/x86/cacheinfo.c @@ -77,7 +77,7 @@ __cache_sysconf (int name) # include extern void __x86_cacheinfo (void) attribute_hidden; -const void (*__x86_cacheinfo_p) (void) attribute_hidden +void (*const __x86_cacheinfo_p) (void) attribute_hidden = __x86_cacheinfo; __ifunc (__x86_cacheinfo, __x86_cacheinfo, NULL, void, init_cacheinfo); diff --git a/sysdeps/x86/dl-get-cpu-features.c b/sysdeps/x86/dl-get-cpu-features.c index 99e3aa7d04..839803c746 100644 --- a/sysdeps/x86/dl-get-cpu-features.c +++ b/sysdeps/x86/dl-get-cpu-features.c @@ -28,7 +28,7 @@ once by IFUNC relocation. In dynamic executable, it is called twice by DL_PLATFORM_INIT and by IFUNC relocation. */ extern void __x86_cpu_features (void) attribute_hidden; -const void (*__x86_cpu_features_p) (void) attribute_hidden +void (*const __x86_cpu_features_p) (void) attribute_hidden = __x86_cpu_features; void