From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 6FA683858D28; Sat, 24 Sep 2022 02:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FA683858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-127dca21a7dso2545786fac.12; Fri, 23 Sep 2022 19:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=IDWtTChBIAX63JbzANRKWCXciffPlAvJ4EdLKfW477g=; b=EUJjX0/fui1kG2xd5APdm1r9BIlmb5z5OBBI/FXq3V1PitimNXoIB4loWmKuMi2cuD EcwE3IuApBI1ODdiXl+xwjC3iLuR82asrSs/T1jKxChzXjNouYjIFjnZwJRnp+fq0EW+ Fv/Lbf3PVwtcfs2LnOZwXvTtF37wxtaR0TVeRZoQilisngSjSReojmg8YoVUR1a3l7K9 qYFt+NAyONYZyr8Rf9yDlq8cBeOplEbLg3olZv0fj9gHm4TSYJiZikIUnlBTwh58HPVM /0m7k1+eiL/rxzWdaxqd0Nfl17mxtORww8931PilpH8i+qSu6NGHt5mJIJZclPhlBTJv rw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=IDWtTChBIAX63JbzANRKWCXciffPlAvJ4EdLKfW477g=; b=QTknyHJoVbrEBBOPtCxSJu0XP9dT8Cw/4U+ruTktd7jj3zAawoHhRR/PrYYgYr4MF5 zawv+K05s6bBGRAqEQx5AyQ073gQYRw/e6BFem1LhLtazwh9i+tqUP6uY4w0+9Hjq0Yf MgU7K7Lbj+N6ols8h5Pf92ph/rjl+kDS1gwTftE2BFKy/2lzj63kQMD8bHu6ngv4uwBR xr1aW24+YLEo1PZYg1hQWFhL0n+xoQmnFeTzrFVCs2SMZB5ha+cmgnD5wGJJ5jQt82tG 0KSkKghFedzM0q+oFJt7Eglhcd42HKRC6CysEGTc0nm+p4fQPvtbwlzYoaQDy3tBoWOY Ld2A== X-Gm-Message-State: ACrzQf1WK/1Ym0hDtsW4a4zdozw/ZsH+1jGb2If27EGftHObyBcB4t4i 7f2hqCwRdb4rg6RG1+OjwqcxBq8tYf750TER8RldDe3MKKc= X-Google-Smtp-Source: AMsMyM5SWg61IrGhuyqPQxbclfwmCgBxS5bGfkLHKtNgxxcR7p8PAx7buQHsQ6T7awfmxYpeZ3BYpCyOSvO1A3bpNdU= X-Received: by 2002:a05:6870:d1d0:b0:12c:cfd2:8285 with SMTP id b16-20020a056870d1d000b0012ccfd28285mr7092308oac.105.1663985557752; Fri, 23 Sep 2022 19:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20210623222846.2162301-1-hjl.tools@gmail.com> <20210623222846.2162301-2-hjl.tools@gmail.com> In-Reply-To: From: Sunil Pandey Date: Fri, 23 Sep 2022 19:12:01 -0700 Message-ID: Subject: Re: [PATCH v8 1/4] math: redirect roundeven function To: =?UTF-8?B?6Kyd5piH6YGUKFNoZW4tVGEgSHNpZWgp?= , Stefan Liebler , Wilco Dijkstra Cc: Noah Goldstein , "H.J. Lu" , Libc-stable Mailing List , Florian Weimer , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 23, 2022 at 3:50 AM =E8=AC=9D=E6=98=87=E9=81=94(Shen-Ta Hsieh) wrote: > > Fine by me, too > > Noah Goldstein =E6=96=BC 2022=E5=B9=B49=E6=9C= =8814=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=889:25=E5=AF=AB=E9=81=93= =EF=BC=9A > > > > On Sun, Sep 11, 2022 at 12:57 PM Sunil Pandey via Libc-stable > > wrote: > > > > > > On Wed, Jun 23, 2021 at 3:32 PM H.J. Lu via Libc-alpha > > > wrote: > > > > > > > > From: Shen-Ta Hsieh > > > > > > > > This patch redirect roundeven function for futhermore changes. > > > > > > > > Signed-off-by: Shen-Ta Hsieh > > > > Reviewed-by: H.J. Lu > > > > --- > > > > include/math.h | 2 +- > > > > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++- > > > > sysdeps/ieee754/float128/s_roundevenf128.c | 1 + > > > > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++ > > > > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 + > > > > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 + > > > > 6 files changed, 10 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/math.h b/include/math.h > > > > index e1c2a4eb64..b4772d3d3b 100644 > > > > --- a/include/math.h > > > > +++ b/include/math.h > > > > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling) > > > > libm_hidden_proto (__issignalingf) > > > > libm_hidden_proto (__exp) > > > > libm_hidden_proto (__expf) > > > > -libm_hidden_proto (__roundeven) > > > > > > > > # if !defined __NO_LONG_DOUBLE_MATH \ > > > > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI =3D=3D 0 > > > > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x) > > > > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS) > > > > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS) > > > > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS) > > > > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS) > > > > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS) > > > > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS) > > > > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS) > > > > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754= /dbl-64/s_roundeven.c > > > > index 943b2c634c..5deff3bb8a 100644 > > > > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c > > > > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c > > > > @@ -16,6 +16,7 @@ > > > > License along with the GNU C Library; if not, see > > > > . */ > > > > > > > > +#define NO_MATH_REDIRECT > > > > #include > > > > #include > > > > #include > > > > @@ -66,5 +67,6 @@ __roundeven (double x) > > > > INSERT_WORDS64 (x, ix); > > > > return x; > > > > } > > > > -hidden_def (__roundeven) > > > > +#ifndef __roundeven > > > > libm_alias_double (__roundeven, roundeven) > > > > +#endif > > > > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/i= eee754/float128/s_roundevenf128.c > > > > index 5a9b3f395f..e0faf727f6 100644 > > > > --- a/sysdeps/ieee754/float128/s_roundevenf128.c > > > > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c > > > > @@ -1,2 +1,3 @@ > > > > +#define NO_MATH_REDIRECT > > > > #include > > > > #include "../ldbl-128/s_roundevenl.c" > > > > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee75= 4/flt-32/s_roundevenf.c > > > > index ae54365bbe..2cc0d7b001 100644 > > > > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c > > > > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c > > > > @@ -17,6 +17,7 @@ > > > > License along with the GNU C Library; if not, see > > > > . */ > > > > > > > > +#define NO_MATH_REDIRECT > > > > #include > > > > #include > > > > #include > > > > @@ -67,4 +68,6 @@ __roundevenf (float x) > > > > SET_FLOAT_WORD (x, ix); > > > > return x; > > > > } > > > > +#ifndef __roundevenf > > > > libm_alias_float (__roundeven, roundeven) > > > > +#endif > > > > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee= 754/ldbl-128/s_roundevenl.c > > > > index 02765be0e0..7c9c11fad2 100644 > > > > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > > > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > > > @@ -17,6 +17,7 @@ > > > > License along with the GNU C Library; if not, see > > > > . */ > > > > > > > > +#define NO_MATH_REDIRECT > > > > #include > > > > #include > > > > #include > > > > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee7= 54/ldbl-96/s_roundevenl.c > > > > index 8340116ed8..f826829c31 100644 > > > > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > > > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > > > @@ -17,6 +17,7 @@ > > > > License along with the GNU C Library; if not, see > > > > . */ > > > > > > > > +#define NO_MATH_REDIRECT > > > > #include > > > > #include > > > > #include > > > > -- > > > > 2.31.1 > > > > > > > > > > I would like to backport this patch to release branch 2.33. > > > > > > Any comments/suggestions or objections on this. > > > > > > commit 447954a206837b5f153869cfeeeab44631c3fac9 > > > Author: Shen-Ta Hsieh > > > Date: Mon May 24 09:43:10 2021 +0800 > > > > > > math: redirect roundeven function > > > > > > This patch redirect roundeven function for futhermore changes. > > > > > > Signed-off-by: Shen-Ta Hsieh > > > Reviewed-by: H.J. Lu > > > > Fine by me. Quick git grep shows that this patch has dependency on architectures other than x86_64. $ git log --grep roundeven --oneline 259a17cc98 s390x: Update math: redirect roundeven function 3213ed770c Update math: redirect roundeven function eb9066203f Use GCC builtins for roundeven functions if desired. 1683249d17 x86_64: roundeven with sse4.1 support 447954a206 math: redirect roundeven function 6a86bc0992 AArch64: Add support for roundeven[f] This may require backporting these patches to other architectures too, where build may potentially break. Not sure if other architecture owners like to backport these patches to 2.3= 3.