From: Sunil Pandey <skpgkp2@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>, libc-stable@sourceware.org
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Florian Weimer <fweimer@redhat.com>,
"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
Hongyu Wang <hongyu.wang@intel.com>,
Thiago Macieira <thiago.macieira@intel.com>,
liuhongt <hongtao.liu@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] x86: Don't set Prefer_No_AVX512 for processors with AVX512 and AVX-VNNI
Date: Fri, 22 Apr 2022 18:51:38 -0700 [thread overview]
Message-ID: <CAMAf5_dswXyNDpzBciejf-3b911i8EXhQedpJ-OEbS=Hz-NOww@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfLnBfseEOHEgZXTaywr3xnv-awUo+Bywdhr7+V4M7Vo9A@mail.gmail.com>
On Tue, Dec 7, 2021 at 11:33 AM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Tue, Dec 7, 2021 at 9:53 AM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > On Tue, Dec 7, 2021 at 7:48 AM Florian Weimer <fweimer@redhat.com> wrote:
> > >
> > > * H. J. Lu via Libc-alpha:
> > >
> > > > On Tue, Dec 7, 2021 at 6:05 AM Florian Weimer <fweimer@redhat.com> wrote:
> > > >>
> > > >> * H. J. Lu via Libc-alpha:
> > > >>
> > > >> > Hongtao, Hongyu, can you find a Rocket Lake to test?
> > > >>
> > > >> I've found a lab machine with an i7-11700 CPU. Is there something I
> > > >> could test for you?
> > > >
> > > > You can enable AVX512 in glibc with:
> > > >
> > > > $ export GLIBC_TUNABLES=glibc.cpu.hwcaps=-Prefer_No_AVX512
> > > >
> > > > While bootstrapping GCC with -j8, track CPU frequency with turbostat. If
> > > > there is no CPU frequency drop and build time is less comparing against
> > > > without GLIBC_TUNABLES, we can enable AVX512.
> > > >
> > > >> (This could be non-production silicon, though.)
> > > >>
> > > >
> > > > The frequency behavior of non-production silicon can be different.
> > >
> > > With that caveat, it seems that frequencies drop further with
> > > GLIBC_TUNABLES set as above, and the build is also a little bit slower
> > > (5m31s vs 5m23s, the AVX-512 build was run first, and the systems was a
> > > little bit warmer for the second run).
> > >
> > > Would it make sense to run more extensive tests, or should we wait for
> > > someone with production silicon to show up?
> >
> > GCC is a heavy user of memcpy/memset, which is a good proxy of
> > ZMM load/store impact on CPU frequency. We need to run the same
> > test on a production Rocket Lake.
>
> I would think a microbenchmark would be better for determining if
> rocketlake actually has throttling.
>
> Testing the full j8 GCC build will add a bunch of frequency "noise"
> due to thermal throttling.
>
> >
> > --
> > H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
parent reply other threads:[~2022-04-23 1:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAFUsyfLnBfseEOHEgZXTaywr3xnv-awUo+Bywdhr7+V4M7Vo9A@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_dswXyNDpzBciejf-3b911i8EXhQedpJ-OEbS=Hz-NOww@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=arjan@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=hongtao.liu@intel.com \
--cc=hongyu.wang@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
--cc=thiago.macieira@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).