From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by sourceware.org (Postfix) with ESMTPS id 503B43858434; Thu, 12 May 2022 19:23:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 503B43858434 Received: by mail-vs1-xe2d.google.com with SMTP id e19so6221489vsu.12; Thu, 12 May 2022 12:23:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cnf9coAEQTn9PcylwDS6cINlbzyAdQTsX3gzB7Zin4g=; b=LbYcUYhvu1skx35KlP3jtqYhZz41Vc8R3fUiD54g3uA8dS/iR2pczVaRx8P2COIW2W I7KptVqY0Wzs/SCSdqVbDXy4kwwMVXCxRp6XVl00RpBBG/Bt3oONZnfA5HqvjW8jzCh2 23OZRbqsuy9erSsavxcwoB//MAfDUCPKHw8op3Fw5Mmt4yZyVtdZ4QbYNFkGXwr0AMbn /wg7pXYkbbAWYDVxmcas0qJT8TqYwBnok9YWeBtF7QKZqVkZWhjTOIRvjmK6b7A3HFEY AXemP4kBcX279h7giLtaUqJyTf/GoiMBauUpTH8rmwVL4z0rrbw4UIZhNnbQcJJ+NJBq 5rjA== X-Gm-Message-State: AOAM530AWtp/Z8IrWPngR27c1JS7++eScjKzmtxuKNFVbfQ7IcvsWiXx CfGvrLS3t1r0+OzGQnicxjGHBGnNS1BKRuBNoF7z5f8fLeE= X-Google-Smtp-Source: ABdhPJzJXzgCCM1UE3ZxvWIXLmzf01IvuAtoBH5mPbIm3Mf7KJPO+7NglYEoUM5C5oiF8YZXusceugTR48KDHTKXSGs= X-Received: by 2002:a67:ee4f:0:b0:32c:ee75:6e98 with SMTP id g15-20020a67ee4f000000b0032cee756e98mr833011vsp.79.1652383418696; Thu, 12 May 2022 12:23:38 -0700 (PDT) MIME-Version: 1.0 References: <20220210195250.4171955-1-hjl.tools@gmail.com> In-Reply-To: From: Sunil Pandey Date: Thu, 12 May 2022 12:23:02 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Remove bzero weak alias in SS2 memset To: "H.J. Lu" , Libc-stable Mailing List Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 19:23:41 -0000 On Mon, Feb 14, 2022 at 8:18 AM H.J. Lu via Libc-alpha wrote: > > On Thu, Feb 10, 2022 at 11:52 AM H.J. Lu wrote: > > > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 > > Author: H.J. Lu > > Date: Mon Feb 7 05:55:15 2022 -0800 > > > > x86-64: Optimize bzero > > > > added the optimized bzero. Remove bzero weak alias in SS2 memset to > > avoid undefined __bzero in memset-sse2-unaligned-erms. > > --- > > sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S > > index 329c58ee46..d52d170804 100644 > > --- a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S > > +++ b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S > > @@ -31,9 +31,7 @@ > > # endif > > > > # undef weak_alias > > -# define weak_alias(original, alias) \ > > - .weak bzero; bzero = __bzero > > - > > +# define weak_alias(original, alias) > > # undef strong_alias > > # define strong_alias(ignored1, ignored2) > > #endif > > -- > > 2.34.1 > > > > I am checking in this patch. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil