From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by sourceware.org (Postfix) with ESMTPS id 60D413884568; Thu, 12 May 2022 19:31:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60D413884568 Received: by mail-vs1-xe35.google.com with SMTP id q2so6273547vsr.5; Thu, 12 May 2022 12:31:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NBaf4RspQm7ofvIsimcsHWAxHqNc96R5VqkkW4HA/9Q=; b=x6BQypgoGfq5yB1jFW+69IFOvAgew6M1/aIM1J7PA9JFPcHSglJ62MpOZUx7Tbward 7UD2ICq32j1oex++n5qFOxi1/bQrP7Tkb/0wxLZ5xXvyFi+nF9vt+vNIQC3pKNrQ81U0 AVtOPesPRpZGGvzlFxgHNoF6xIJG3J7Z5FN7Abfn6xoNlJfeWPUAP/o2jGaVqnIwBDxg dh6JAJCUtcm9FYYK1+GNXe6FyBYQrsf+2+uA+GMeXH0mdtUvF+PNIO5Ng3s69LyRpuGE ipKlW2VTszYQc4R0lyyrodlECjp/dznS1sFTxn6wq2lviCaILZYO3PRVZFOVeQUbDDlt u0Aw== X-Gm-Message-State: AOAM530R2qnQPkz8nryQUWGQADWe1SykF8F3Jg6YgThF62qTeY0HTgmq KazoFSZGNJOi+nis0nx8ydzkogVCF1tMKcOqio7k9RovthA= X-Google-Smtp-Source: ABdhPJziJpCFfim13hdeMV/bjaGSFVNCDWg+zunjWxP/eGEdZKog6ycWgWdNGkDO7dQhx0FwXE3l1zvNe6YSNMC9CpE= X-Received: by 2002:a67:ee4f:0:b0:32c:ee75:6e98 with SMTP id g15-20020a67ee4f000000b0032cee756e98mr844732vsp.79.1652383900738; Thu, 12 May 2022 12:31:40 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-3-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Thu, 12 May 2022 12:31:04 -0700 Message-ID: Subject: Re: [PATCH v1 03/23] x86: Code cleanup in strchr-avx2 and comment justifying branch To: "H.J. Lu" , Libc-stable Mailing List Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 19:31:44 -0000 On Thu, Mar 24, 2022 at 12:37 PM H.J. Lu via Libc-alpha wrote: > > On Thu, Mar 24, 2022 at 12:20 PM Noah Goldstein wrote: > > > > On Thu, Mar 24, 2022 at 1:53 PM H.J. Lu wrote: > > > > > > On Wed, Mar 23, 2022 at 2:58 PM Noah Goldstein wrote: > > > > > > > > Small code cleanup for size: -53 bytes. > > > > > > > > Add comment justifying using a branch to do NULL/non-null return. > > > > > > > > > Do you have followup patches to improve its performance? We are > > > backporting all x86-64 improvements to Intel release branches: > > > > > > https://gitlab.com/x86-glibc/glibc/-/wikis/home > > > > > > Patches without performance improvements are undesirable. > > > > No further changes planned at the moment, code size saves > > seem worth it for master though. Also in favor of adding the comment > > as I think its non-intuitive. > > > > LGTM. > > Reviewed-by: H.J. Lu > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil