From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id A2A383858C56; Wed, 4 May 2022 05:45:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2A383858C56 Received: by mail-vk1-xa32.google.com with SMTP id n135so130732vkn.7; Tue, 03 May 2022 22:45:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=clGxpzDQJ8GbCSt6QGAKkRyf9g9Ul9kRwCsaFXx9fQ8=; b=slMtfajsHA5vFORwXWMUbwUsP8uFNcc4+bG9kwv9ewp6bRcrObFQEmWEbFIfIewEPa dzAsg0yC/7rqNxuCrvhUHC/RG9cbEGgw3EQ/yG7/nqWLuOZJOWcKsNSCjjsHpaAOYhub 3vX3o+PnBfLGSiGlYf+XXoF2FKeEY9E2d8CSp+USRW3JpYtFuc3rKOQuefI4vgFfbEJI nEYX6+ko/n50VbLRCqnfuRevGQYuPENgNe0E9qgbXrM7ug//Gx6Z1INLBj5Z81c3+Pgl OLwGaWXzcrPkT4u7llt2yoMJJ2QudFriL2sUJ71TgS6oEuZMBsJA73fSDwjwwqu2EwG2 fw2A== X-Gm-Message-State: AOAM533gVA7QtAQuTigdGUuxxHR1Tf3FAx81H1/DHWjMgW7yvb8FDnzK 9vq6YcV7LRUKeKaQbRfaC6iinmOR2AAiM+ZOFwJBb8KLvls= X-Google-Smtp-Source: ABdhPJznkeuWzsaDUs1GjbWSHo5jvGGVqNZggchtEmeTus0LXzRbov6YDtzQkuU4+u8XikAahWK3Y9xEOp6WSgHzD6I= X-Received: by 2002:a1f:2fd0:0:b0:34e:8f1e:9953 with SMTP id v199-20020a1f2fd0000000b0034e8f1e9953mr5106247vkv.41.1651643118081; Tue, 03 May 2022 22:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220204191200.73982-1-hjl.tools@gmail.com> <20220204191200.73982-2-hjl.tools@gmail.com> In-Reply-To: <20220204191200.73982-2-hjl.tools@gmail.com> From: Sunil Pandey Date: Tue, 3 May 2022 22:44:41 -0700 Message-ID: Subject: Re: [PATCH 2/2] x86-64: Fix strcmp-evex.S To: "H.J. Lu" , Libc-stable Mailing List Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 05:45:20 -0000 On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha wrote: > > Change "movl %edx, %rdx" to "movl %edx, %edx" in: > > commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9 > Author: Noah Goldstein > Date: Mon Jan 10 15:35:39 2022 -0600 > > x86: Optimize strcmp-evex.S > --- > sysdeps/x86_64/multiarch/strcmp-evex.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S > index e5070f3d53..6f42e3155a 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S > @@ -116,7 +116,7 @@ ENTRY(STRCMP) > # ifdef USE_AS_STRNCMP > # ifdef __ILP32__ > /* Clear the upper 32 bits. */ > - movl %edx, %rdx > + movl %edx, %edx > # endif > cmp $1, %RDX_LP > /* Signed comparison intentional. We use this branch to also > -- > 2.34.1 > I would like to backport this patch to release branches. Any comments or objections? --Sunil