From: Sunil Pandey <skpgkp2@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/2] x86-64: Fix strcmp-avx2.S
Date: Tue, 3 May 2022 22:42:49 -0700 [thread overview]
Message-ID: <CAMAf5_e=Fi5+x6Azk072VxGuZHXEwPT=yZ7rnOiYoec==fRp2g@mail.gmail.com> (raw)
In-Reply-To: <20220204191200.73982-1-hjl.tools@gmail.com>
On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date: Mon Jan 10 15:35:38 2022 -0600
>
> x86: Optimize strcmp-avx2.S
> ---
> sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> index 28d6a0025a..99e5349be8 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> @@ -106,7 +106,7 @@ ENTRY(STRCMP)
> # ifdef USE_AS_STRNCMP
> # ifdef __ILP32__
> /* Clear the upper 32 bits. */
> - movl %edx, %rdx
> + movl %edx, %edx
> # endif
> cmp $1, %RDX_LP
> /* Signed comparison intentional. We use this branch to also
> --
> 2.34.1
>
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
next parent reply other threads:[~2022-05-04 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220204191200.73982-1-hjl.tools@gmail.com>
2022-05-04 5:42 ` Sunil Pandey [this message]
[not found] ` <20220204191200.73982-2-hjl.tools@gmail.com>
2022-05-04 5:44 ` [PATCH 2/2] x86-64: Fix strcmp-evex.S Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_e=Fi5+x6Azk072VxGuZHXEwPT=yZ7rnOiYoec==fRp2g@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).