From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by sourceware.org (Postfix) with ESMTPS id 96CA03858C56; Wed, 4 May 2022 05:43:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96CA03858C56 Received: by mail-vk1-xa2f.google.com with SMTP id y27so127238vkl.8; Tue, 03 May 2022 22:43:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lsj7PV7EDsI2dwTLO572AEEH718G3YintKm22eypjUc=; b=OlDJgmN2NdkRQE39kveYcgdWjp2I0pOjHrYe+pIfs9yq3OplrfOfEGG7aJXc7ppwer l26U881x1kGZrNkhqX5lu1sXA6fjPxC6L8GpPlK0dk5rAvpLsCcSZ9C2RP8ZjpiiKXVS hp81DQCEiELLPtSs9x9UWzU3E0YArNZhaWoJdptdSDqVmR7E3jOCkWzwuhYG4OnhlXW5 GaUR7CBGFTTQP+5ywAud7rsXIVYWB2OmJadlMhuusH+ZkhitPLimD/6R881BdejPxPTs ig4/hVQ3i3X9AvMMXNWv6WYrf1GTjlXTQWferr+5T0vAeH+7/upNkVRHREg0OwmlBDmu LmCA== X-Gm-Message-State: AOAM532+P1kwC/AzRxHu48oKCs8u+Cm/z4gBNvd467aN77obUpgrrpQb vkq3O92oCaI0FxMgOli6vTH6PFbpvK+Zg0WdbOw= X-Google-Smtp-Source: ABdhPJw64GoJMW56lCaMa4qgYIvHPwkBVRtxuqarDLqJNU79Xax++othk59ETqMVajAOR4HTN87HnGUiChDdIo6G1Mg= X-Received: by 2002:a1f:6003:0:b0:34d:3d07:5827 with SMTP id u3-20020a1f6003000000b0034d3d075827mr5710976vkb.30.1651643005952; Tue, 03 May 2022 22:43:25 -0700 (PDT) MIME-Version: 1.0 References: <20220204191200.73982-1-hjl.tools@gmail.com> In-Reply-To: <20220204191200.73982-1-hjl.tools@gmail.com> From: Sunil Pandey Date: Tue, 3 May 2022 22:42:49 -0700 Message-ID: Subject: Re: [PATCH 1/2] x86-64: Fix strcmp-avx2.S To: "H.J. Lu" , Libc-stable Mailing List Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 05:43:29 -0000 On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha wrote: > > Change "movl %edx, %rdx" to "movl %edx, %edx" in: > > commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45 > Author: Noah Goldstein > Date: Mon Jan 10 15:35:38 2022 -0600 > > x86: Optimize strcmp-avx2.S > --- > sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > index 28d6a0025a..99e5349be8 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > @@ -106,7 +106,7 @@ ENTRY(STRCMP) > # ifdef USE_AS_STRNCMP > # ifdef __ILP32__ > /* Clear the upper 32 bits. */ > - movl %edx, %rdx > + movl %edx, %edx > # endif > cmp $1, %RDX_LP > /* Signed comparison intentional. We use this branch to also > -- > 2.34.1 > I would like to backport this patch to release branches. Any comments or objections? --Sunil