From: Sunil Pandey <skpgkp2@gmail.com>
To: Fangrui Song <maskray@google.com>, libc-stable@sourceware.org
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86-64: Replace movzx with movzbl
Date: Fri, 22 Apr 2022 18:36:42 -0700 [thread overview]
Message-ID: <CAMAf5_eAWgKRbBscfg0Yk3WvrtgytQMfakbNdD6=4AD7cEMY0A@mail.gmail.com> (raw)
In-Reply-To: <20211103011531.yiuufsybf5e56rnt@google.com>
On Tue, Nov 2, 2021 at 6:16 PM Fangrui Song via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On 2021-11-02, H.J. Lu wrote:
> >On Tue, Nov 2, 2021 at 1:45 PM Fangrui Song <maskray@google.com> wrote:
> >>
> >> Clang cannot assemble movzx in the AT&T dialect mode.
> >>
> >> ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction
> >> movzx (%rsi), %ecx
> >> ^~~~
> >>
> >> Change movzx to movzbl, which follows the AT&T dialect and is used
> >> elsewhere in the file.
> >> ---
> >> sysdeps/x86_64/strcmp.S | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S
> >> index c7cbe4042a..bfe83abede 100644
> >> --- a/sysdeps/x86_64/strcmp.S
> >> +++ b/sysdeps/x86_64/strcmp.S
> >> @@ -2229,8 +2229,8 @@ LABEL(strcmp_exitz):
> >>
> >> .p2align 4
> >> LABEL(Byte0):
> >> - movzx (%rsi), %ecx
> >> - movzx (%rdi), %eax
> >> + movzbl (%rsi), %ecx
> >> + movzbl (%rdi), %eax
> >>
> >> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> >> leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
> >> --
> >> 2.33.1.1089.g2158813163f-goog
> >>
> >
> >LGTM.
> >
> >Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> >Thanks.
>
> Thanks for the quick review!
>
> Just noticed that sysdeps/x86_64/multiarch/strcmp-sse42.S has a similar
> pattern which needs fixing as well. I'll fix that, too.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
parent reply other threads:[~2022-04-23 1:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20211103011531.yiuufsybf5e56rnt@google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_eAWgKRbBscfg0Yk3WvrtgytQMfakbNdD6=4AD7cEMY0A@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).