From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 84B983847718 for ; Wed, 3 Apr 2024 22:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84B983847718 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84B983847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712183613; cv=none; b=bEk9eTp4Wsq5qIyO803khtLW5ffgpZy6W4dOdvOh92KWNQaO3U17y+XIgCdVaCCTO8qJz8efH1uU9CayFp5MZQkVdcZUxe8uE+2nWPz/m2ZTbvYNq4ozNWJExilKHXU5HEcUjqKLw3Jj9T93R5xTSlu6CuiitLhWPAcH6Om3YCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712183613; c=relaxed/simple; bh=goC1uiywD8aAT/pC5ONia/IQPv5i2VpeKQ/mFyu2uj4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=vVBrJLbFSUYTZO7bssZpav7pgohK4MSk5gESG/svetXhD4WE6dPYBim0DQHIghitTJ2M7BQIbMgBmSnfyajl5TYq6UbD7+NJWr6cb9VBTXX56FmS8e8L81MVqpBnTApn1SiuRcZELrC1CB0oa8j6UqTt8FF9sgA1eyGscRLcN1I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4162a3e2cacso1133505e9.1 for ; Wed, 03 Apr 2024 15:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712183609; x=1712788409; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YGqGbto0VrWWDNXdEYxuXfSgdA2mUiQXPEwN2HIl++0=; b=bKvIMUF3f6gPlWN59UVy6cmWl9YRZrdHYL8/5zukzSx9uxWzDHi2jHLaW6yJlsJWDU AgeRU3I6ruXYQUThhAx1eb+wzQuoR/0q5SynjdcyE7O7KiSo0Jxyz1F1MBHTQwWnpohD t+rFSo5dC/+ScUrzS1aM5MpD+aGHFG5TZhOorxalWakRaLS+wxxx/0IYM5Ltrdyo9Fsv JMaNyIR7xRIo2/Xm1tfx3MKyh76vzXVl0ZAGs9Ql/DkbAcvT5kRP2mGIETGFUo3O+7ru ztCTQdytOhyp4BAVwWeTrWoLHGcc0KJojBCHDuhsUKNSXoI6RFVCkONVUUjRW9MGuhjq Jvyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712183609; x=1712788409; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YGqGbto0VrWWDNXdEYxuXfSgdA2mUiQXPEwN2HIl++0=; b=BA5EXm97R6GSVGrLLVr3Ladyw5Aly1w8EhGw9LOiQGW6g9Q5dSdD1ScPOZ12VuBrS8 sdO8wuH5LKeKwkv5IdgKy8r0pb6B+MOoXtUTmAOQUuEwC1TKpltNIHS2QjXAqi6eQRf/ SFvyn/+jBCmxHDfRzCqXJSE7Fvy0NQOkmgzGAtD0fvsRkAm0LC+FeLZPbRvgntk3z0XO wxqx2xql9Fvm1GKdn7q+JedyGzu5m9xIF1KBMGJo1BEaUXj4aKXze7c8oK6U3mDgUpdm LE120/7C5ZZfFTB7bxGdyVf06BMM/j0jlOPunRP+1hm5cyTLBB6+taDHbB4AJyfqAnNe gg7w== X-Gm-Message-State: AOJu0YzUnIpNGnV/I6HJACuRzY8Wc3JZfgRZ5FP2kqrqIdekuJgy4GZq y++2JpT7TgjuUmMX70n4X5/r1YDU3w4lJoZOUFaexhh0ptRRMxn34FosaiSFuvRMa1V/7BIiPR1 NlSTmffVNSc6Tdi49CK2fyb3W+MA= X-Google-Smtp-Source: AGHT+IGg7xmkuDYPO0sewafOf5Tp6ihTYjs1vqCFi/Nqi/11Z9ltN5C95+5T9eWn/4x4dNHdcjlnCAGWcvN67B9Yrdc= X-Received: by 2002:a05:600c:3b8f:b0:415:641c:3838 with SMTP id n15-20020a05600c3b8f00b00415641c3838mr675507wms.4.1712183608911; Wed, 03 Apr 2024 15:33:28 -0700 (PDT) MIME-Version: 1.0 References: <20240402132723.807729-1-hjl.tools@gmail.com> In-Reply-To: <20240402132723.807729-1-hjl.tools@gmail.com> From: Sunil Pandey Date: Wed, 3 Apr 2024 15:32:52 -0700 Message-ID: Subject: Re: [Backport: v2 0/7] Update _dl_tlsdesc_dynamic to preserve caller-saved registers To: "H.J. Lu" Cc: libc-stable@sourceware.org, fweimer@redhat.com, adhemerval.zanella@linaro.org, carlos@redhat.com, goldstein.w.n@gmail.com Content-Type: multipart/alternative; boundary="000000000000ccb2e2061538cf82" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ccb2e2061538cf82 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 2, 2024 at 6:27=E2=80=AFAM H.J. Lu wrote: > Changes in v2: > > 1. Add tst-gnu2-tls2mod1 to test-internal-extras. > > --- > GNU2 TLS descriptor instruction sequences have implicit _dl_tlsdesc_dynam= ic > call and compilers assume that caller-saved registers are unchanged after > call. Update _dl_tlsdesc_dynamic to preserve caller-saved registers. > > Adhemerval Zanella (3): > Ignore undefined symbols for -mtls-dialect=3Dgnu2 > arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ > 31372) > elf: Enable TLS descriptor tests on aarch64 > > Andreas Schwab (1): > Add tst-gnu2-tls2mod1 to test-internal-extras > > H.J. Lu (3): > x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers > x86-64: Update _dl_tlsdesc_dynamic to preserve AMX registers > x86-64: Allocate state buffer space for RDI, RSI and RBX > > config.h.in | 3 + > configure | 25 ++- > configure.ac | 17 +- > elf/Makefile | 34 +++- > elf/tst-gnu2-tls2.c | 122 +++++++++++ > elf/tst-gnu2-tls2.h | 40 ++++ > elf/tst-gnu2-tls2mod0.c | 32 +++ > elf/tst-gnu2-tls2mod1.c | 32 +++ > elf/tst-gnu2-tls2mod2.c | 32 +++ > sysdeps/aarch64/preconfigure | 1 + > sysdeps/arm/Makefile | 8 +- > sysdeps/arm/configure | 32 +++ > sysdeps/arm/configure.ac | 15 ++ > sysdeps/arm/dl-tlsdesc.S | 70 ++++++- > sysdeps/arm/tst-gnu2-tls2.h | 128 ++++++++++++ > sysdeps/i386/dl-machine.h | 2 +- > sysdeps/i386/dl-tlsdesc-dynamic.h | 190 ++++++++++++++++++ > sysdeps/i386/dl-tlsdesc.S | 115 +++++------ > sysdeps/unix/sysv/linux/x86_64/Makefile | 27 +++ > .../sysv/linux/x86_64/include/asm/prctl.h | 5 + > .../linux/x86_64/tst-gnu2-tls2-amx-mod0.c | 2 + > .../linux/x86_64/tst-gnu2-tls2-amx-mod1.c | 2 + > .../linux/x86_64/tst-gnu2-tls2-amx-mod2.c | 2 + > .../sysv/linux/x86_64/tst-gnu2-tls2-amx.c | 83 ++++++++ > .../sysv/linux/x86_64/tst-gnu2-tls2-amx.h | 63 ++++++ > sysdeps/x86/Makefile | 7 +- > sysdeps/x86/cpu-features-offsets.sym | 1 + > sysdeps/x86/cpu-features.c | 118 ++++++++++- > sysdeps/x86/dl-procinfo.c | 16 ++ > sysdeps/{x86_64 =3D> x86}/features-offsets.sym | 2 + > sysdeps/x86/include/cpu-features.h | 2 + > sysdeps/x86/sysdep.h | 78 ++++++- > sysdeps/x86/tst-gnu2-tls2.c | 20 ++ > sysdeps/x86_64/Makefile | 4 +- > sysdeps/x86_64/configure | 28 +++ > sysdeps/x86_64/configure.ac | 15 ++ > sysdeps/x86_64/dl-machine.h | 19 +- > sysdeps/x86_64/dl-procinfo.c | 16 ++ > sysdeps/x86_64/dl-tlsdesc-dynamic.h | 166 +++++++++++++++ > sysdeps/x86_64/dl-tlsdesc.S | 108 +++------- > sysdeps/x86_64/dl-trampoline-save.h | 34 ++++ > sysdeps/x86_64/dl-trampoline-state.h | 51 +++++ > sysdeps/x86_64/dl-trampoline.S | 20 +- > sysdeps/x86_64/dl-trampoline.h | 34 +--- > sysdeps/x86_64/tst-gnu2-tls2mod1.S | 87 ++++++++ > 45 files changed, 1644 insertions(+), 264 deletions(-) > create mode 100644 elf/tst-gnu2-tls2.c > create mode 100644 elf/tst-gnu2-tls2.h > create mode 100644 elf/tst-gnu2-tls2mod0.c > create mode 100644 elf/tst-gnu2-tls2mod1.c > create mode 100644 elf/tst-gnu2-tls2mod2.c > create mode 100644 sysdeps/arm/tst-gnu2-tls2.h > create mode 100644 sysdeps/i386/dl-tlsdesc-dynamic.h > create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod0= .c > create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod1= .c > create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod2= .c > create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.c > create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.h > rename sysdeps/{x86_64 =3D> x86}/features-offsets.sym (89%) > create mode 100644 sysdeps/x86/tst-gnu2-tls2.c > create mode 100644 sysdeps/x86_64/dl-tlsdesc-dynamic.h > create mode 100644 sysdeps/x86_64/dl-trampoline-save.h > create mode 100644 sysdeps/x86_64/dl-trampoline-state.h > create mode 100644 sysdeps/x86_64/tst-gnu2-tls2mod1.S > > -- > 2.44.0 > > LGTM --Sunil --000000000000ccb2e2061538cf82--