From: Sunil Pandey <skpgkp2@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, libc-stable@sourceware.org
Cc: Noah Goldstein <goldstein.w.n@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1] x86: Replace sse2 instructions with avx in memcmp-evex-movbe.S
Date: Fri, 22 Apr 2022 18:22:18 -0700 [thread overview]
Message-ID: <CAMAf5_eT5-VL_mhTWCbg=fdgydbQ6js2kdWg-HCsN_6OYx_J7g@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOpbtWPRAej5-hWcfVUBns_DsKeJqaoPJf0jmveGGy3zXQ@mail.gmail.com>
On Sat, Oct 23, 2021 at 6:22 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Fri, Oct 22, 2021 at 10:26 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > This commit replaces two usages of SSE2 'movups' with AVX 'vmovdqu'.
> >
> > it could potentially be dangerous to use SSE2 if this function is ever
> > called without using 'vzeroupper' beforehand. While compilers appear
> > to use 'vzeroupper' before function calls if AVX2 has been used, using
> > SSE2 here is more brittle. Since it is not absolutely necessary it
> > should be avoided.
> >
> > It costs 2-extra bytes but the extra bytes should only eat into
> > alignment padding.
> > ---
> > sysdeps/x86_64/multiarch/memcmp-evex-movbe.S | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memcmp-evex-movbe.S b/sysdeps/x86_64/multiarch/memcmp-evex-movbe.S
> > index 2761b54f2e..640f6757fa 100644
> > --- a/sysdeps/x86_64/multiarch/memcmp-evex-movbe.S
> > +++ b/sysdeps/x86_64/multiarch/memcmp-evex-movbe.S
> > @@ -561,13 +561,13 @@ L(between_16_31):
> > /* From 16 to 31 bytes. No branch when size == 16. */
> >
> > /* Use movups to save code size. */
> > - movups (%rsi), %xmm2
> > + vmovdqu (%rsi), %xmm2
> > VPCMP $4, (%rdi), %xmm2, %k1
> > kmovd %k1, %eax
> > testl %eax, %eax
> > jnz L(return_vec_0_lv)
> > /* Use overlapping loads to avoid branches. */
> > - movups -16(%rsi, %rdx, CHAR_SIZE), %xmm2
> > + vmovdqu -16(%rsi, %rdx, CHAR_SIZE), %xmm2
> > VPCMP $4, -16(%rdi, %rdx, CHAR_SIZE), %xmm2, %k1
> > addl $(CHAR_PER_VEC - (16 / CHAR_SIZE)), %edx
> > kmovd %k1, %eax
> > --
> > 2.29.2
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>
> --
> H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
parent reply other threads:[~2022-04-23 1:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAMe9rOpbtWPRAej5-hWcfVUBns_DsKeJqaoPJf0jmveGGy3zXQ@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAf5_eT5-VL_mhTWCbg=fdgydbQ6js2kdWg-HCsN_6OYx_J7g@mail.gmail.com' \
--to=skpgkp2@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).