From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by sourceware.org (Postfix) with ESMTPS id CDA8F3858C56; Wed, 4 May 2022 05:40:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDA8F3858C56 Received: by mail-vk1-xa29.google.com with SMTP id o132so123318vko.11; Tue, 03 May 2022 22:40:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ntAIJJdmLldhmzv1nR1/lSANvFHIL5yGziw9Whu/rJ8=; b=Z5GyU0iSvQwQq9YXqHmYOUg0Rf0qWtON+8NVuVoXvJn7KCTTkIAhsxIVHvh3HVRHPk xRyMHGaXKGS9HwKTTdJTMT4FP+Gqj8mUYZy59xu3mbvw9Fwm0Rh+ek2R9jy7HqRLuAu5 iZxBS0LJXvxcBVTyHzyZDKBUTgSACY8/QgsA7e9XnxpbvthnVMBMA5nwvHbmfQmJajUW YeRoq135m19rJ+95I1o6MyEhxQ63gZqklpFKpjQHlJjVmTGJZji67XSV9F3BuIOuo3Uy FW+FFZaQoh3Qr5LEepYanVcbGLNkDsCxjG1IoJYpAa7Ysp25+E5VboJgcI8JmM9S12HA mfwA== X-Gm-Message-State: AOAM530zMZocriPlCeglRGFG3YT5w1+SjCFT5FrOMe8hzq3X/yHsziKF NpjAaeBfzCpmC+6x5YqsN2FHs7V7ot9fMY2awpMi7hKiors= X-Google-Smtp-Source: ABdhPJyc1igJntn53oCcOqsOVnYZ//HjvoTP+N45BWbU06BRejpJQKhQKIVgagccOJf2M3BZFaZ1aMl/xihKZviyj5U= X-Received: by 2002:a1f:5c81:0:b0:351:dddc:a5ef with SMTP id q123-20020a1f5c81000000b00351dddca5efmr1769396vkb.19.1651642850189; Tue, 03 May 2022 22:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220203214215.3275256-1-goldstein.w.n@gmail.com> <20220203214215.3275256-3-goldstein.w.n@gmail.com> In-Reply-To: From: Sunil Pandey Date: Tue, 3 May 2022 22:40:13 -0700 Message-ID: Subject: Re: [PATCH v4 3/5] x86: Optimize strcmp-avx2.S To: "H.J. Lu" , Libc-stable Mailing List Cc: Joseph Myers , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 05:40:52 -0000 On Fri, Feb 4, 2022 at 11:14 AM H.J. Lu via Libc-alpha wrote: > > On Fri, Feb 4, 2022 at 10:57 AM Joseph Myers wrote: > > > > I've seeing a build failure for x32 that looks likely to be caused by this > > patch. > > > > ../sysdeps/x86_64/multiarch/strcmp-avx2.S: Assembler messages: > > ../sysdeps/x86_64/multiarch/strcmp-avx2.S:109: Error: unsupported instruction `mov' > > /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/sysd-rules:847: recipe for target '/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o' failed > > make[3]: *** [/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o] Error 1 > > > > Fixed by: > > commit 0e0199a9e02ebe42e2b36958964d63f03573c382 > Author: H.J. Lu > Date: Fri Feb 4 11:11:08 2022 -0800 > > x86-64: Fix strcmp-evex.S > > Change "movl %edx, %rdx" to "movl %edx, %edx" in: > > commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9 > Author: Noah Goldstein > Date: Mon Jan 10 15:35:39 2022 -0600 > > x86: Optimize strcmp-evex.S > > commit c15efd011cea3d8f0494269eb539583215a1feed > Author: H.J. Lu > Date: Fri Feb 4 11:09:10 2022 -0800 > > x86-64: Fix strcmp-avx2.S > > Change "movl %edx, %rdx" to "movl %edx, %edx" in: > > commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45 > Author: Noah Goldstein > Date: Mon Jan 10 15:35:38 2022 -0600 > > x86: Optimize strcmp-avx2.S > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil