From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 8A4523858D3C; Mon, 2 May 2022 14:00:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A4523858D3C Received: by mail-vs1-xe2c.google.com with SMTP id v139so13711234vsv.0; Mon, 02 May 2022 07:00:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b2WbHWTI7tDORmHyj9qaHhR8aQe/rtSYjJd/2VCSveU=; b=L59rGKTQbQ0skp4kmTXeRs7dcB0lQw7FOGzTp/WwT4VQ735BOW420JMMYlzD7QSAXU kJEzcac7CaCQPBkvWScxTepHorbIBPv00FvZyaEOAxugWftoPiq4RsL/QXUrXbcLppAG w82mzx9kCVxEeZd09dGlm0RjStWnQcbFCkwOSw2RtCMDBv282qX68WiFLL4Yf1gP4Dtc JO702HBQu2vJW6nZqaDYs9NyXqlrCmp98r4KSMpOEwwNPYOfk6h1V+uC3+KusrTYfkr0 JXdAOyzwrGQpWZcwv63OqsCDViuI9X0mBwklo4JdySEcA9vXP3fBcP8PgE1HWX/ezSRD Cv8g== X-Gm-Message-State: AOAM532LxGw78ce+/iiG4qxKVRjzZ/eYP8zh+oPymH1a+y68K6ZcaaKC EdCHPrCy+6xbenJU6YdC4TzgF0DFsJHozgjQVPk= X-Google-Smtp-Source: ABdhPJwfk/pPGUVW3fVcEwJS/xwf4KjsTHbGftCWeDRpwcqJZ5oKGEkzrTbWhxOD/2OQCvrT2kbmb/golypPubVajyw= X-Received: by 2002:a67:ef0a:0:b0:32d:4bb9:23f with SMTP id j10-20020a67ef0a000000b0032d4bb9023fmr348693vsr.47.1651500018906; Mon, 02 May 2022 07:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-2-hjl.tools@gmail.com> <87imby6obw.fsf@oldenburg2.str.redhat.com> <87y2ku574k.fsf@oldenburg2.str.redhat.com> <87lfgu56c8.fsf@oldenburg2.str.redhat.com> <87pn663qm5.fsf@oldenburg2.str.redhat.com> <87ft71yq64.fsf@oldenburg2.str.redhat.com> <87362yl4fh.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: Sunil Pandey Date: Mon, 2 May 2022 06:59:42 -0700 Message-ID: Subject: Re: PING^2: V4 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] To: "H.J. Lu" , Libc-stable Mailing List Cc: Florian Weimer , "H.J. Lu via Libc-alpha" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-stable@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-stable mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 14:00:21 -0000 On Thu, Oct 15, 2020 at 5:54 AM H.J. Lu via Libc-alpha wrote: > > On Thu, Oct 8, 2020 at 6:22 AM H.J. Lu wrote: > > > > On Thu, Oct 1, 2020 at 12:50 PM H.J. Lu wrote: > > > > > > On Thu, Oct 1, 2020 at 1:46 AM Florian Weimer wr= ote: > > > > > > > > * H. J. Lu: > > > > > > > > > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c > > > > > index dadec5d58f..65ab29123d 100644 > > > > > --- a/sysdeps/x86/cacheinfo.c > > > > > +++ b/sysdeps/x86/cacheinfo.c > > > > > @@ -16,7 +16,9 @@ > > > > > License along with the GNU C Library; if not, see > > > > > . */ > > > > > > > > > > -#if IS_IN (libc) > > > > > +/* NB: In libc.a, this file is included in libc-static.c. In li= bc.so, > > > > > + this file is standalone. */ > > > > > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEAT= URES_H) > > > > > > > > libc-static.c should be libc-start.c, I believe. The =E2=80=9Cdefi= ned > > > > _PRIVATE_CPU_FEATURES_H=E2=80=9D part seems rather indirect. What = exactly are > > > > you trying to accomplish here? > > > > > > > > It looks to me as if this file should included in libc.so, but not > > > > pulled into ld.so via the rebuild, so maybe you can add an empty > > > > sysdeps/x86/rtld-cacheinfo.c file instead? > > > > > > > > > > Here is the updated patch. I also moved files around to prepare > > > for moving x86 processor cache info to cpu_features in ld.so to > > > support --list-tunables. > > > > > > > PING: > > > > https://sourceware.org/pipermail/libc-alpha/2020-October/118228.html > > > > I will check it in tomorrow if there are no objections. > > Thanks. > > -- > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil